Skip to content

Commit e79de6a

Browse files
committed
Tidy up Watcher components
1 parent 51e1194 commit e79de6a

File tree

9 files changed

+14
-23
lines changed

9 files changed

+14
-23
lines changed

src/Nest/Nest.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1381,13 +1381,13 @@
13811381
<Compile Include="XPack\Watcher\Input\ConnectionScheme.cs" />
13821382
<Compile Include="XPack\Watcher\Input\HttpInputProxy.cs" />
13831383
<Compile Include="XPack\Watcher\Input\HttpMethod.cs" />
1384-
<Compile Include="XPack\Watcher\Input\IChainInput.cs" />
1384+
<Compile Include="XPack\Watcher\Input\ChainInput.cs" />
13851385
<Compile Include="XPack\Watcher\Input\InputBase.cs" />
13861386
<Compile Include="XPack\Watcher\Input\IndicesOptions.cs" />
13871387
<Compile Include="XPack\Watcher\Input\InputType.cs" />
13881388
<Compile Include="XPack\Watcher\Input\ResponseContentType.cs" />
13891389
<Compile Include="XPack\Watcher\Input\SimpleInput.cs" />
1390-
<Compile Include="XPack\Watcher\PutWatch\Actions.cs" />
1390+
<Compile Include="XPack\Watcher\Action\Actions.cs" />
13911391
<Compile Include="XPack\Watcher\RestartWatcher\ElasticClient-RestartWatcher.cs" />
13921392
<Compile Include="XPack\Watcher\RestartWatcher\RestartWatcherResponse.cs" />
13931393
<Compile Include="XPack\Watcher\Schedule\CronExpression.cs" />

src/Nest/XPack/Watcher/PutWatch/Actions.cs renamed to src/Nest/XPack/Watcher/Action/Actions.cs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,9 @@ private static IDictionary<string, IAction> ReduceCombinators(IDictionary<string
3434
return reducedActions;
3535
}
3636

37-
public Actions()
38-
{
39-
}
37+
public Actions() {}
4038

41-
public Actions(IDictionary<string, IAction> actions) : base(ReduceCombinators(actions))
42-
{
43-
}
39+
public Actions(IDictionary<string, IAction> actions) : base(ReduceCombinators(actions)) {}
4440

4541
public static implicit operator Actions(ActionBase action)
4642
{
@@ -70,9 +66,7 @@ public static implicit operator Actions(ActionBase action)
7066

7167
public class ActionsDescriptor : IsADictionaryDescriptorBase<ActionsDescriptor, Actions, string, IAction>
7268
{
73-
public ActionsDescriptor() : base(new Actions())
74-
{
75-
}
69+
public ActionsDescriptor() : base(new Actions()) {}
7670

7771
public ActionsDescriptor Email(string name, Func<EmailActionDescriptor, IEmailAction> selector) =>
7872
Assign(name, selector.InvokeOrDefault(new EmailActionDescriptor(name)));

src/Nest/XPack/Watcher/Condition/AlwaysCondition.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace Nest
44
{
5-
65
[JsonObject]
76
[JsonConverter(typeof(ReadAsTypeJsonConverter<AlwaysCondition>))]
87
public interface IAlwaysCondition : ICondition {}

src/Nest/XPack/Watcher/Condition/ConditionBase.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,8 @@ namespace Nest
55
[JsonObject]
66
public interface ICondition {}
77

8-
public abstract class ConditionBase
8+
public abstract class ConditionBase : ICondition
99
{
10-
11-
1210
internal abstract void WrapInContainer(IConditionContainer container);
1311
}
1412
}

src/Nest/XPack/Watcher/Condition/ConditionType.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ public enum ConditionType
1414
[EnumMember(Value="script")]
1515
Script,
1616
[EnumMember(Value = "compare")]
17-
Compare
17+
Compare,
18+
[EnumMember(Value = "array_compare")]
19+
ArrayCompare
1820
}
1921
}
File renamed without changes.

src/Nest/XPack/Watcher/Input/SimpleInput.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ public void Remove(string key)
3737
_payload?.Remove(key);
3838
}
3939

40-
public static implicit operator InputContainer(SimpleInput input) => input == null
41-
? null
42-
: new InputContainer(input);
43-
4440
internal override void WrapInContainer(IInputContainer container) => container.Simple = this;
4541

4642
public IEnumerator<KeyValuePair<string, object>> GetEnumerator()
@@ -50,7 +46,7 @@ public IEnumerator<KeyValuePair<string, object>> GetEnumerator()
5046

5147
IEnumerator IEnumerable.GetEnumerator()
5248
{
53-
return ((IEnumerable)_payload).GetEnumerator();
49+
return this.GetEnumerator();
5450
}
5551
}
5652

src/Nest/XPack/Watcher/Schedule/ScheduleBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ namespace Nest
55
[JsonObject]
66
public interface ISchedule {}
77

8-
public abstract class ScheduleBase
8+
public abstract class ScheduleBase : ISchedule
99
{
1010
internal abstract void WrapInContainer(IScheduleContainer container);
1111
}

src/Nest/XPack/Watcher/Trigger/TriggerBase.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
namespace Nest
22
{
3-
public abstract class TriggerBase
3+
public interface ITrigger {}
4+
5+
public abstract class TriggerBase : ITrigger
46
{
57
public static implicit operator TriggerContainer(TriggerBase trigger) => trigger == null
68
? null

0 commit comments

Comments
 (0)