Commit de942bd
committed
Checking in keys scary but:
Do not rely on strong names for security. They provide a unique identity only. (https://msdn.microsoft.com/en-us/library/wd40t7ad.aspx)
Firstly, we would recommend that these open source projects check-in their private key (https://github.com/dotnet/corefx/wiki/Strong%20Naming)
And this twitter conversation:
https://twitter.com/Mpdreamz/status/534971537271816192
This removes our complicated prebuild that creates keys if not present. We can not simply call sn.exe over our compiled dlls because our dlls also depend on eachother which means msbuild needs to do the signing.1 parent e40c144 commit de942bd
File tree
8 files changed
+1
-25
lines changed- build/keys
- src
- Connections
- Elasticsearch.Net.Connection.HttpClient
- Elasticsearch.Net.Connection.Thrift
- Elasticsearch.Net
- Nest
- Serialization/Elasticsearch.Net.JsonNet
8 files changed
+1
-25
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 37 | | |
43 | 38 | | |
| 39 | + | |
44 | 40 | | |
45 | 41 | | |
46 | 42 | | |
| |||
Binary file not shown.
Binary file not shown.
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | 66 | | |
71 | 67 | | |
72 | 68 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | 135 | | |
140 | 136 | | |
141 | 137 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | 138 | | |
143 | 139 | | |
144 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1067 | 1067 | | |
1068 | 1068 | | |
1069 | 1069 | | |
1070 | | - | |
1071 | | - | |
1072 | | - | |
1073 | | - | |
1074 | 1070 | | |
1075 | 1071 | | |
1076 | 1072 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | 67 | | |
72 | 68 | | |
73 | 69 | | |
| |||
0 commit comments