Fix stack overflow when accessing ApiCall and build on .net core

Author: gmarz

src/Nest/CommonAbstractions/Response/ResponseBase.cs

@@ -21,23 +21,17 @@ public interface IResponse : IBodyWithApiCallDetails
 		[JsonIgnore]
 		bool IsValid { get; }
 
-		/// <summary>
-		/// Returns the <see cref="IApiCallDetails"/> diagnostic information
-		/// </summary>
-		[JsonIgnore]
-		new IApiCallDetails ApiCall { get; }
-
 		/// <summary>
 		/// If the response results in an error on elasticsearch's side an <pre>error</pre> element will be returned, this is mapped to <see cref="ServerError"/> in NEST.
-		/// <para>This property is a shortcut to <see cref="ApiCall"/>'s <see cref="IApiCallDetails.ServerError"/> and is possibly set when <see cref="IsValid"/> is false depending on the cause of the error</para>
+		/// <para>This property is a shortcut to <see cref="IBodyWithApiCallDetails.ApiCall"/>'s <see cref="IApiCallDetails.ServerError"/> and is possibly set when <see cref="IsValid"/> is false depending on the cause of the error</para>
 		/// <para>You can also configure the client to always throw an <see cref="ElasticsearchClientException"/> using <see cref="IConnectionConfigurationValues.ThrowExceptions"/> if the response is not valid</para>
 		/// </summary>
 		[JsonIgnore]
 		ServerError ServerError { get; }
 
 		/// <summary>
 		/// If the request resulted in an exception on the client side this will hold the exception that was thrown.
-		/// <para>This property is a shortcut to <see cref="ApiCall"/>'s <see cref="IApiCallDetails.OriginalException"/> and is possibly set when <see cref="IsValid"/> is false depending on the cause of the error</para>
+		/// <para>This property is a shortcut to <see cref="IBodyWithApiCallDetails.ApiCall"/>'s <see cref="IApiCallDetails.OriginalException"/> and is possibly set when <see cref="IsValid"/> is false depending on the cause of the error</para>
 		/// <para>You can also configure the client to always throw an <see cref="ElasticsearchClientException"/> using <see cref="IConnectionConfigurationValues.ThrowExceptions"/> if the response is not valid</para>
 		/// </summary>
 		[JsonIgnore]
@@ -59,7 +53,7 @@ public abstract class ResponseBase : IResponse
 		IApiCallDetails IBodyWithApiCallDetails.ApiCall { get; set; }
 
 		/// <inheritdoc/>
-		public virtual IApiCallDetails ApiCall => ((IBodyWithApiCallDetails)this).ApiCall;
+		protected virtual IApiCallDetails ApiCall => ((IBodyWithApiCallDetails)this).ApiCall;
 
 		/// <inheritdoc/>
 		public virtual ServerError ServerError => this.ApiCall?.ServerError;

src/Nest/Search/Search/SearchResponse.cs

@@ -42,7 +42,7 @@ public interface ISearchResponse<T> : IResponse where T : class
 	public class SearchResponse<T> : ResponseBase, ISearchResponse<T> where T : class
 	{
 		internal ServerError MultiSearchError { get; set; }
-		public override IApiCallDetails ApiCall => MultiSearchError != null ? new ApiCallDetailsOverride(base.ApiCall, MultiSearchError) : base.ApiCall;
+		protected override IApiCallDetails ApiCall => MultiSearchError != null ? new ApiCallDetailsOverride(base.ApiCall, MultiSearchError) : base.ApiCall;
 
 		[JsonProperty(PropertyName = "_shards")]
 		public ShardsMetaData Shards { get; internal set; }

src/Tests/ClientConcepts/Exceptions/ExceptionTests.cs

@@ -60,7 +60,7 @@ public void ServerTestWhenThrowExceptionsDisabled()
 			var response = client.GetMapping<Project>(s => s.Index("doesntexist"));
 #if DOTNETCORE
 			// HttpClient does not throw on "known error" status codes (i.e. 404) thus OriginalException should not be set
-			response.CallDetails.OriginalException.Should().BeNull();
+			response.ApiCall.OriginalException.Should().BeNull();
 #else
 			response.ApiCall.OriginalException.Should().NotBeNull();
 #endif
@@ -76,7 +76,7 @@ public void ClientTestWhenThrowExceptionsDisabled()
 			var response = client.RootNodeInfo();
 #if DOTNETCORE
 			// HttpClient does not throw on "known error" status codes (i.e. 404) thus OriginalException should not be set
-			response.CallDetails.OriginalException.Should().BeNull();
+			response.ApiCall.OriginalException.Should().BeNull();
 #else
 			response.ApiCall.OriginalException.Should().NotBeNull();
 #endif