fix #487 YesNoBoolConverter does not handle true/false properly if yes no is expected but a real boolean is returned

Author: Mpdreamz

src/Nest/Domain/Mapping/Types/StringMapping.cs

@@ -28,7 +28,6 @@ public class StringMapping : IElasticType, IElasticCoreType
 		[JsonProperty("analyzer")]
 		public string Analyzer { get; set; }
 
-		[JsonProperty("store"), JsonConverter(typeof(YesNoBoolConverter))]
 		public bool? Store { get; set; }
 
 		[JsonProperty("index"), JsonConverter(typeof(StringEnumConverter))]

src/Nest/Resolvers/Converters/YesNoBoolConverter.cs

@@ -18,7 +18,8 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			return reader.Value != null && reader.Value.ToString() == "yes";
+			var v = reader.Value.ToString();
+			return reader.Value != null && (v == "yes" || v == "True");
 		}
 
 		public override bool CanConvert(Type objectType)

src/Tests/Nest.Tests.Integration/Mapping/MapTests.cs

@@ -63,8 +63,6 @@ public void SimpleMapByAttributes()
 		}
 
 
-
-
 		[Test]
 		public void SimpleMapByAttributesUsingType()
 		{

src/Tests/Nest.Tests.Integration/Reproduce/Reproduce487Tests.cs

@@ -0,0 +1,47 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using Nest.Tests.MockData;
+using Nest.Tests.MockData.Domain;
+using NUnit.Framework;
+using System.Diagnostics;
+using FluentAssertions;
+
+namespace Nest.Tests.Integration.Reproduce
+{
+	[TestFixture]
+	public class Reproduce487Tests : IntegrationTests
+	{
+		public class Post
+		{
+			public int Id { get; set; }
+			public string Name { get; set; }
+		}
+
+
+		/// <summary>
+		/// https://github.com/Mpdreamz/NEST/issues/487
+		/// </summary>
+		[Test]
+		public void NoSearchResults()
+		{
+			var index = ElasticsearchConfiguration.NewUniqueIndexName();
+			var x = this._client.CreateIndex(index, s => s
+				.AddMapping<ElasticsearchProject>(m => m
+					.Properties(pp=>pp
+						.String(sm=>sm.Name(p=>p.Name).Store())
+					)
+				)
+			);
+			Assert.IsTrue(x.Acknowledged, x.ConnectionStatus.ToString());
+
+			var typeMapping = this._client.GetMapping(i => i.Index(index).Type("elasticsearchprojects"));
+			typeMapping.Should().NotBeNull();
+			var stringMapping = typeMapping.Mapping.Properties["name"] as StringMapping;
+			stringMapping.Should().NotBeNull();
+			stringMapping.Store.Should().HaveValue();
+			stringMapping.Store.Should().BeTrue();
+		}
+
+	}
+}