Skip to content

Commit b70f502

Browse files
committed
Ignore xpack run as tests again now that we're testing against rc1
1 parent 1e6aa2c commit b70f502

File tree

2 files changed

+64
-62
lines changed

2 files changed

+64
-62
lines changed

src/Tests/XPack/Security/Role/PutRole/PutRoleApiTests.cs

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -94,34 +94,35 @@ protected override void ExpectResponse(IPutRoleResponse response)
9494
}
9595

9696
//TODO this might be a bug in xpack but more likely a misunderstanding on our part ignore for now
97-
public class PutRoleRunAsApiTests : PutRoleApiTests
98-
{
99-
public PutRoleRunAsApiTests(XPackCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
100-
101-
protected override bool ExpectIsValid => false;
102-
protected override int ExpectStatusCode => 403;
103-
104-
protected override PutRoleRequest Initializer
105-
{
106-
get
107-
{
108-
var request = base.Initializer;
109-
request.RequestConfiguration = new RequestConfiguration
110-
{
111-
RunAs = ShieldInformation.User.Username
112-
};
113-
return request;
114-
}
115-
}
116-
117-
protected override Func<PutRoleDescriptor, IPutRoleRequest> Fluent => f => base.Fluent(f
118-
.RequestConfiguration(c => c
119-
.RunAs(ShieldInformation.User.Username)
120-
));
121-
122-
protected override void ExpectResponse(IPutRoleResponse response)
123-
{
124-
}
125-
}
97+
// https://github.com/elastic/x-plugins/issues/3617
98+
//public class PutRoleRunAsApiTests : PutRoleApiTests
99+
//{
100+
// public PutRoleRunAsApiTests(XPackCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
101+
102+
// protected override bool ExpectIsValid => false;
103+
// protected override int ExpectStatusCode => 403;
104+
105+
// protected override PutRoleRequest Initializer
106+
// {
107+
// get
108+
// {
109+
// var request = base.Initializer;
110+
// request.RequestConfiguration = new RequestConfiguration
111+
// {
112+
// RunAs = ShieldInformation.User.Username
113+
// };
114+
// return request;
115+
// }
116+
// }
117+
118+
// protected override Func<PutRoleDescriptor, IPutRoleRequest> Fluent => f => base.Fluent(f
119+
// .RequestConfiguration(c => c
120+
// .RunAs(ShieldInformation.User.Username)
121+
// ));
122+
123+
// protected override void ExpectResponse(IPutRoleResponse response)
124+
// {
125+
// }
126+
//}
126127

127128
}

src/Tests/XPack/Security/User/PutUser/PutUserApiTests.cs

Lines changed: 34 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -76,38 +76,39 @@ protected override void ExpectResponse(IPutUserResponse response)
7676
}
7777

7878
//TODO disabled for now pending bug report
79-
public class PutUserRunAsApiTests : PutUserApiTests
80-
{
81-
public PutUserRunAsApiTests(XPackCluster cluster, EndpointUsage usage) : base(cluster, usage)
82-
{
83-
var x = this.Client.GetUser(new GetUserRequest(ShieldInformation.User.Username));
84-
var y = this.Client.GetRole(new GetRoleRequest(ShieldInformation.User.Role));
85-
}
86-
87-
protected override bool ExpectIsValid => false;
88-
protected override int ExpectStatusCode => 403;
89-
90-
protected override PutUserRequest Initializer
91-
{
92-
get
93-
{
94-
var request = base.Initializer;
95-
request.RequestConfiguration = new RequestConfiguration
96-
{
97-
RunAs = ShieldInformation.User.Username
98-
};
99-
return request;
100-
}
101-
}
102-
103-
protected override Func<PutUserDescriptor, IPutUserRequest> Fluent => f => base.Fluent(f
104-
.RequestConfiguration(c => c
105-
.RunAs(ShieldInformation.User.Username)
106-
));
107-
108-
protected override void ExpectResponse(IPutUserResponse response)
109-
{
110-
}
111-
}
79+
// https://github.com/elastic/x-plugins/issues/3617
80+
//public class PutUserRunAsApiTests : PutUserApiTests
81+
//{
82+
// public PutUserRunAsApiTests(XPackCluster cluster, EndpointUsage usage) : base(cluster, usage)
83+
// {
84+
// var x = this.Client.GetUser(new GetUserRequest(ShieldInformation.User.Username));
85+
// var y = this.Client.GetRole(new GetRoleRequest(ShieldInformation.User.Role));
86+
// }
87+
88+
// protected override bool ExpectIsValid => false;
89+
// protected override int ExpectStatusCode => 403;
90+
91+
// protected override PutUserRequest Initializer
92+
// {
93+
// get
94+
// {
95+
// var request = base.Initializer;
96+
// request.RequestConfiguration = new RequestConfiguration
97+
// {
98+
// RunAs = ShieldInformation.User.Username
99+
// };
100+
// return request;
101+
// }
102+
// }
103+
104+
// protected override Func<PutUserDescriptor, IPutUserRequest> Fluent => f => base.Fluent(f
105+
// .RequestConfiguration(c => c
106+
// .RunAs(ShieldInformation.User.Username)
107+
// ));
108+
109+
// protected override void ExpectResponse(IPutUserResponse response)
110+
// {
111+
// }
112+
//}
112113

113114
}

0 commit comments

Comments
 (0)