Skip to content

Commit 9248dff

Browse files
committed
Add DetectNoop back as a request body parameter
Closes #1786
1 parent 3fba15d commit 9248dff

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

src/Nest/Document/Single/Update/UpdateRequest.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ public partial interface IUpdateRequest<TDocument, TPartialDocument>
3434

3535
[JsonProperty(PropertyName = "doc")]
3636
TPartialDocument Doc { get; set; }
37+
38+
[JsonProperty(PropertyName = "detect_noop")]
39+
bool? DetectNoop { get; set; }
3740
}
3841

3942
public partial class UpdateRequest<TDocument, TPartialDocument>
@@ -47,6 +50,7 @@ public partial class UpdateRequest<TDocument, TPartialDocument>
4750
public TDocument Upsert { get; set; }
4851
public bool? DocAsUpsert { get; set; }
4952
public TPartialDocument Doc { get; set; }
53+
public bool? DetectNoop { get; set; }
5054

5155
public Fields Fields
5256
{
@@ -75,6 +79,7 @@ public partial class UpdateDescriptor<TDocument, TPartialDocument>
7579

7680
TPartialDocument IUpdateRequest<TDocument, TPartialDocument>.Doc { get; set; }
7781

82+
bool? IUpdateRequest<TDocument, TPartialDocument>.DetectNoop { get; set; }
7883

7984
public UpdateDescriptor<TDocument, TPartialDocument> Script(string script) => Assign(a => a.Script = script);
8085

@@ -95,7 +100,9 @@ public UpdateDescriptor<TDocument, TPartialDocument> Params(Func<FluentDictionar
95100
/// </summary>
96101
public UpdateDescriptor<TDocument, TPartialDocument> Doc(TPartialDocument @object) => Assign(a => a.Doc = @object);
97102

98-
public UpdateDescriptor<TDocument, TPartialDocument> DocAsUpsert(bool? docAsUpsert = true) => Assign(a => a.DocAsUpsert = docAsUpsert);
103+
public UpdateDescriptor<TDocument, TPartialDocument> DocAsUpsert(bool docAsUpsert = true) => Assign(a => a.DocAsUpsert = docAsUpsert);
104+
105+
public UpdateDescriptor<TDocument, TPartialDocument> DetectNoop(bool detectNoop = true) => Assign(a => a.DetectNoop = detectNoop);
99106

100107
public UpdateDescriptor<TDocument, TPartialDocument> Fields(Fields fields) =>
101108
Assign(a => a.RequestParameters.AddQueryString("fields", fields));

src/Tests/Document/Single/Update/UpdateApiTests.cs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,22 @@ protected override LazyResponses ClientUsage() => Calls(
3737
protected override object ExpectJson { get; } = new
3838
{
3939
doc = Project.InstanceAnonymous,
40-
doc_as_upsert = true
40+
doc_as_upsert = true,
41+
detect_noop = true
4142
};
4243

4344
protected override UpdateDescriptor<Project, Project> NewDescriptor() => new UpdateDescriptor<Project, Project>(DocumentPath<Project>.Id(CallIsolatedValue));
4445

45-
protected override Func<UpdateDescriptor<Project,Project>, IUpdateRequest<Project, Project>> Fluent => d=>d
46-
.Doc(Project.Instance)
47-
.DocAsUpsert();
46+
protected override Func<UpdateDescriptor<Project, Project>, IUpdateRequest<Project, Project>> Fluent => d => d
47+
.Doc(Project.Instance)
48+
.DocAsUpsert()
49+
.DetectNoop();
4850

4951
protected override UpdateRequest<Project, Project> Initializer => new UpdateRequest<Project, Project>(CallIsolatedValue)
5052
{
5153
Doc = Project.Instance,
52-
DocAsUpsert = true
54+
DocAsUpsert = true,
55+
DetectNoop = true
5356
};
5457
}
5558
}

0 commit comments

Comments
 (0)