updated projects to exclude xmldoc warnings (they add little value and push more interesting warnings into obscurity, fixed remaining warnings except for the ones that caused Elasticsearch.Net to be no longer CLSCompliant

Author: Mpdreamz

src/CodeGeneration/CodeGeneration.LowLevelClient/ApiGenerator.cs

@@ -160,9 +160,6 @@ public static void PatchMethod(CsharpMethod method)
 				method.DescriptorTypeGeneric = generic;
 			else method.Unmapped = true;
 
-
-
-
 			try
 			{
 				var typeName = "CodeGeneration.LowLevelClient.Overrides.Descriptors." + method.DescriptorType + "Overrides";
@@ -173,24 +170,30 @@ public static void PatchMethod(CsharpMethod method)
 				if (overrides == null)
 					return;
 
+				var globalQueryStringRenames = new Dictionary<string, string>
+				{
+					{"__source", "_source_enabled"},
+					{"__source_include", "_source_include"},
+					{"__source_exclude", "_source_exclude"},
+				};
+				var qs = overrides.RenameQueryStringParams ?? new Dictionary<string, string>();
+				foreach (var kv in globalQueryStringRenames)
+					qs[kv.Key] = kv.Value;
+
 				foreach (var kv in method.Url.Params)
 				{
 					if (overrides.SkipQueryStringParams.Contains(kv.Key))
 						method.Url.Params.Remove(kv.Key);
-
-					if (overrides.RenameQueryStringParams == null) continue;
 
+
 					string newName;
-					if (!overrides.RenameQueryStringParams.TryGetValue(kv.Key, out newName))
+					if (!qs.TryGetValue(kv.Key, out newName))
 						continue;
 
 					method.Url.Params.Remove(kv.Key);
 					method.Url.Params.Add(newName, kv.Value);
 
 				}
-
-				//method.Url.Params = method.Url.Params.Where(p => !overrides.SkipQueryStringParams.Contains(p.Key))
-				//	.ToDictionary(k => k.Key, v => v.Value);
 			}
 // ReSharper disable once EmptyGeneralCatchClause
 			catch 

src/CodeGeneration/CodeGeneration.LowLevelClient/CodeGeneration.LowLevelClient.csproj

@@ -32,6 +32,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>1591,1572,1571,1573,1587,1570</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug - Generator|AnyCPU'">
     <DebugSymbols>true</DebugSymbols>

src/CodeGeneration/CodeGeneration.LowLevelClient/Overrides/Descriptors/UpdateDescriptorOverrides.cs

@@ -16,4 +16,5 @@ public IEnumerable<string> SkipQueryStringParams
 		}
 		public IDictionary<string, string> RenameQueryStringParams { get { return null; } }
 	}
+	
 }

src/CodeGeneration/CodeGeneration.LowLevelClient/Views/RawDispatch.Generated.cshtml

@@ -9,7 +9,7 @@ using System.Text;
 using System.Threading.Tasks;
 using Elasticsearch.Net;
 
-///Generated File Please Do Not Edit Manually
+//Generated File Please Do Not Edit Manually
 @{ RestApiSpec model = Model; }
 
 namespace Nest

src/CodeGeneration/CodeGeneration.LowLevelClient/Views/RequestParameters.Generated.cshtml

@@ -8,9 +8,9 @@ using System.Linq;
 using System.Text;
 using System.Linq.Expressions;
 
-///This file contains all the typed querystring parameters that are generated of the client spec.
-///This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec
-///Generated of commit @Model.Commit
+//This file contains all the typed querystring parameters that are generated of the client spec.
+//This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec
+//Generated of commit @Model.Commit
 
 namespace Elasticsearch.Net
 {

src/CodeGeneration/CodeGeneration.LowLevelClient/Views/_Descriptors.Generated.cshtml

@@ -9,9 +9,10 @@ using System.Linq;
 using System.Text;
 using System.Linq.Expressions;
 using Elasticsearch.Net;
-///This file lays the base for all the descriptors based on the query string parameters in the spec for IElasticClient.
-///This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec
-///Generated of commit @Model.Commit
+
+//This file lays the base for all the descriptors based on the query string parameters in the spec for IElasticClient.
+//This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec
+//Generated of commit @Model.Commit
 
 namespace Nest
 {

src/CodeGeneration/CodeGeneration.LowLevelClient/Views/_Requests.Generated.cshtml

@@ -11,9 +11,9 @@ using System.Text;
 using System.Linq.Expressions;
 using Elasticsearch.Net;
 
-///This file contains all the typed querystring parameters that are generated of the client spec.
-///This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec
-///Generated of commit @Model.Commit
+//This file contains all the typed querystring parameters that are generated of the client spec.
+//This file is automatically generated from https://github.com/elasticsearch/elasticsearch-rest-api-spec
+//Generated of commit @Model.Commit
 
 namespace Nest
 {

src/CodeGeneration/CodeGeneration.YamlTestsRunner/CodeGeneration.YamlTestsRunner.csproj

@@ -30,6 +30,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>1591,1572,1571,1573,1587,1570</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="CsQuery">

src/Connections/Elasticsearch.Net.Connection.HttpClient/Elasticsearch.Net.Connection.HttpClient.csproj

@@ -31,6 +31,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <Prefer32Bit>false</Prefer32Bit>
+    <NoWarn>1591,1572,1571,1573,1587,1570</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="System" />

src/Connections/Elasticsearch.Net.Connection.Thrift/Elasticsearch.Net.Connection.Thrift.csproj

@@ -52,6 +52,7 @@
     <CodeAnalysisIgnoreBuiltInRules>false</CodeAnalysisIgnoreBuiltInRules>
     <WarningLevel>4</WarningLevel>
     <DocumentationFile>bin\Release\Elasticsearch.Net.Connection.Thrift.XML</DocumentationFile>
+    <NoWarn>1591,1572,1571,1573,1587,1570</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug - Generator|AnyCPU'">
     <DebugSymbols>true</DebugSymbols>
@@ -151,4 +152,4 @@
   <Target Name="AfterBuild">
   </Target>
   -->
-</Project>
+</Project>