Remove parameterless ctor, renamed Value => ValueOf

Author: gmarz

src/Nest/CommonAbstractions/Fields/FieldValues.cs

@@ -15,26 +15,24 @@ public class FieldValues : IsADictionary<string, object>
 	{
 		private ElasticInferrer _inferrer;
 
-		public FieldValues() : base() { }
-
 		public FieldValues(ElasticInferrer inferrer, IDictionary<string, object> container) 
 			: base(container)
 		{
 			_inferrer = inferrer;
 		}
 
-		public K Value<K>(Field field) => Values<K>(field).FirstOrDefault();
+		public K ValueOf<K>(Field field) => ValuesOf<K>(field).FirstOrDefault();
 
-		public K Value<T, K>(Expression<Func<T, object>> objectPath) 
-			where T : class => Values<T, K>(objectPath).FirstOrDefault();
+		public K ValueOf<T, K>(Expression<Func<T, object>> objectPath) 
+			where T : class => ValuesOf<T, K>(objectPath).FirstOrDefault();
 
-		public K[] Values<K>(Field field)
+		public K[] ValuesOf<K>(Field field)
 		{
 			var path = this._inferrer.Field(field);
 			return this.FieldArray<K[]>(path);
 		}
 
-		public K[] Values<T, K>(Expression<Func<T, object>> objectPath)
+		public K[] ValuesOf<T, K>(Expression<Func<T, object>> objectPath)
 			where T : class
 		{
 			var field = this._inferrer.Field(objectPath);

src/Tests/Aggregations/Metric/TopHits/TopHitsAggregationUsageTests.cs

@@ -167,9 +167,9 @@ protected override void ExpectResponse(ISearchResponse<Project> response)
 				hits.All(h => h.Explanation != null).Should().BeTrue();
 				hits.All(h => h.Version.HasValue).Should().BeTrue();
 				//hits.All(h => h.Highlights.Count() > 0).Should().BeTrue();
-				hits.All(h => h.Fields.Values<StateOfBeing>("state").Any()).Should().BeTrue();
-				hits.All(h => h.Fields.Values<int>("numberOfCommits").Any()).Should().BeTrue();
-				hits.All(h => h.Fields.Values<int>("commit_factor").Any()).Should().BeTrue();
+				hits.All(h => h.Fields.ValuesOf<StateOfBeing>("state").Any()).Should().BeTrue();
+				hits.All(h => h.Fields.ValuesOf<int>("numberOfCommits").Any()).Should().BeTrue();
+				hits.All(h => h.Fields.ValuesOf<int>("commit_factor").Any()).Should().BeTrue();
 				topStateHits.Documents<Project>().Should().NotBeEmpty();
 			}
 		}

src/Tests/Document/Single/Get/GetApiTests.cs

@@ -60,8 +60,8 @@ public GetApiFieldsTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cl
 		protected override void ExpectResponse(IGetResponse<Project> response)
 		{
 			response.Fields.Should().NotBeNull();
-			response.Fields.Value<Project, string>(p => p.Name).Should().Be(ProjectId);
-			response.Fields.Value<Project, int>(p => p.NumberOfCommits).Should().BeGreaterThan(0);
+			response.Fields.ValueOf<Project, string>(p => p.Name).Should().Be(ProjectId);
+			response.Fields.ValueOf<Project, int>(p => p.NumberOfCommits).Should().BeGreaterThan(0);
 		}
 	}
 }

src/Tests/Search/Request/InnerHitsUsageTests.cs

@@ -214,7 +214,7 @@ [I] public Task AssertResponse() => this.AssertOnAllResponses(r =>
 				earlHits.Total.Should().BeGreaterThan(0);
 				earlHits.Hits.Should().NotBeEmpty().And.HaveCount(5);
 				foreach (var earlHit in earlHits.Hits)
-					earlHit.Fields.Values<string>("name").Should().NotBeEmpty();
+					earlHit.Fields.ValuesOf<string>("name").Should().NotBeEmpty();
 				var earls = earlHits.Documents<Earl>();
 				earls.Should().NotBeEmpty().And.OnlyContain(earl => !string.IsNullOrWhiteSpace(earl.Name));
 				foreach (var earlHit in earlHits.Hits)