remove IConnectionSettings interface unused so should break exisiting code that uses it

Author: Mpdreamz

build/build.fsx

@@ -69,7 +69,7 @@ let nugetPack = fun name ->
     CreateDir nugetOutDir
 
     let dir = sprintf "%s/%s/" buildDir name
-    let version = "1.0.0-alpha1"
+    let version = "1.0.0-alpha4"
     NuGetPack (fun p ->
       {p with 
         Version = version

src/Nest/ConvenienceExtensions/SerializerExtensions.cs

@@ -3,8 +3,9 @@
 using System.IO;
 using System.Linq;
 using System.Text;
+using Elasticsearch.Net.Serialization;
 
-namespace Nest
+namespace Nest.SerializationExtensions
 {
 	public static class SerializerExtensions
 	{
@@ -16,10 +17,11 @@ public static class SerializerExtensions
 		/// <typeparam name="T">The type to deserialize to</typeparam>
 		/// <param name="serializer"></param>
 		/// <param name="data">The string representation of the data to be deserialized</param>
-		public static T Deserialize<T>(this INestSerializer serializer, string data)
+		public static T Deserialize<T>(this IElasticClient client, string data)
 		{
 			using (var ms = new MemoryStream(Encoding.UTF8.GetBytes(data)))
-				return serializer.Deserialize<T>(null, ms, null);
+				return client.Serializer.Deserialize<T>(null, ms, null);
 		}
+		
 	}
 }

src/Nest/Domain/Connection/IConnectionSettings.cs

@@ -9,71 +9,74 @@
 
 namespace Nest
 {
-	/// <summary>
-	/// Control how NEST's behaviour.
-	/// </summary>
-	public interface IConnectionSettings : IConnectionSettings<IConnectionSettings>, IConnectionConfigurationValues
-	{
+	//TODO Remove
+
+
+	///// <summary>
+	///// Control how NEST's behaviour.
+	///// </summary>
+	//public interface IConnectionSettings : IConnectionSettings<IConnectionSettings>, IConnectionConfigurationValues
+	//{
 
-	}
-	public interface IConnectionSettings<out T> : IConnectionConfiguration<T> where T : IConnectionSettings<T>
-	{
+	//}
+	//public interface IConnectionSettings<out T> : IConnectionConfiguration<T> where T : IConnectionSettings<T>
+	//{
 
-		/// <summary>
-		/// This calls SetDefaultTypenameInferrer with an implementation that will pluralize type names.
-		/// This used to be the default prior to Nest 1.0
-		/// </summary>
-		/// <returns></returns>
-		T PluralizeTypeNames();
+	//	/// <summary>
+	//	/// This calls SetDefaultTypenameInferrer with an implementation that will pluralize type names.
+	//	/// This used to be the default prior to Nest 1.0
+	//	/// </summary>
+	//	/// <returns></returns>
+	//	T PluralizeTypeNames();
 
-		/// <summary>
-		/// Allows you to update internal the json.net serializer settings to your liking
-		/// </summary>
-		/// <param name="modifier"></param>
-		/// <returns></returns>
-		T SetJsonSerializerSettingsModifier(Action<JsonSerializerSettings> modifier);
+	//	/// <summary>
+	//	/// Allows you to update internal the json.net serializer settings to your liking
+	//	/// </summary>
+	//	/// <param name="modifier"></param>
+	//	/// <returns></returns>
+	//	T SetJsonSerializerSettingsModifier(Action<JsonSerializerSettings> modifier);
 
-		/// <summary>
-		/// Add a custom JsonConverter to the build in json serialization by passing in a predicate for a type.
-		/// This is faster then adding them using AddJsonConverters() because this way they will be part of the cached 
-		/// Json.net contract for a type.
-		/// </summary>
-		T AddContractJsonConverters(params Func<Type, JsonConverter>[] contractSelectors);
+	//	/// <summary>
+	//	/// Add a custom JsonConverter to the build in json serialization by passing in a predicate for a type.
+	//	/// This is faster then adding them using AddJsonConverters() because this way they will be part of the cached 
+	//	/// Json.net contract for a type.
+	//	/// </summary>
+	//	T AddContractJsonConverters(params Func<Type, JsonConverter>[] contractSelectors);
 
 
-		/// <summary>
-		/// Index to default to when no index is specified.
-		/// </summary>
-		/// <param name="defaultIndex">When null/empty/not set might throw NRE later on
-		/// when not specifying index explicitly while indexing.
-		/// </param>
-		/// <returns></returns>
-		T SetDefaultIndex(string defaultIndex);
+	//	/// <summary>
+	//	/// Index to default to when no index is specified.
+	//	/// </summary>
+	//	/// <param name="defaultIndex">When null/empty/not set might throw NRE later on
+	//	/// when not specifying index explicitly while indexing.
+	//	/// </param>
+	//	/// <returns></returns>
+	//	T SetDefaultIndex(string defaultIndex);
 
 
-		/// <summary>
-		/// By default NEST camelCases property names (EmailAddress => emailAddress) that do not have an explicit propertyname 
-		/// either via an ElasticProperty attribute or because they are part of Dictionary where the keys should be treated verbatim.
-		/// <pre>
-		/// Here you can register a function that transforms propertynames (default casing, pre- or suffixing)
-		/// </pre>
-		/// </summary>
-		T SetDefaultPropertyNameInferrer(Func<string, string> propertyNameSelector);
+	//	/// <summary>
+	//	/// By default NEST camelCases property names (EmailAddress => emailAddress) that do not have an explicit propertyname 
+	//	/// either via an ElasticProperty attribute or because they are part of Dictionary where the keys should be treated verbatim.
+	//	/// <pre>
+	//	/// Here you can register a function that transforms propertynames (default casing, pre- or suffixing)
+	//	/// </pre>
+	//	/// </summary>
+	//	T SetDefaultPropertyNameInferrer(Func<string, string> propertyNameSelector);
 
-		/// <summary>
-		/// Allows you to override how type names should be reprented, the default will call .ToLowerInvariant() on the type's name.
-		/// </summary>
-		T SetDefaultTypeNameInferrer(Func<Type, string> defaultTypeNameInferrer);
+	//	/// <summary>
+	//	/// Allows you to override how type names should be reprented, the default will call .ToLowerInvariant() on the type's name.
+	//	/// </summary>
+	//	T SetDefaultTypeNameInferrer(Func<Type, string> defaultTypeNameInferrer);
 
 
-		/// <summary>
-		/// Map types to a index names. Takes precedence over SetDefaultIndex().
-		/// </summary>
-		T MapDefaultTypeIndices(Action<FluentDictionary<Type, string>> mappingSelector);
+	//	/// <summary>
+	//	/// Map types to a index names. Takes precedence over SetDefaultIndex().
+	//	/// </summary>
+	//	T MapDefaultTypeIndices(Action<FluentDictionary<Type, string>> mappingSelector);
 
-		/// <summary>
-		/// Allows you to override typenames, takes priority over the global SetDefaultTypeNameInferrer()
-		/// </summary>
-		T MapDefaultTypeNames(Action<FluentDictionary<Type, string>> mappingSelector);
-	}
+	//	/// <summary>
+	//	/// Allows you to override typenames, takes priority over the global SetDefaultTypeNameInferrer()
+	//	/// </summary>
+	//	T MapDefaultTypeNames(Action<FluentDictionary<Type, string>> mappingSelector);
+	//}
 }

src/Nest/ElasticClient.cs

@@ -40,7 +40,6 @@ public ElasticClient(
 			IConnection connection = null, 
 			INestSerializer serializer = null)
 		{
-
 			this._connectionSettings = settings ?? new ConnectionSettings();
 			this.Connection = connection ?? new HttpConnection(settings);
 

src/Nest/Nest.csproj

@@ -98,6 +98,7 @@
     <Compile Include="ConvenienceExtensions\GetMappingExtensions.cs" />
     <Compile Include="ConvenienceExtensions\OpenCloseIndexExtensions.cs" />
     <Compile Include="ConvenienceExtensions\ScrollExtensions.cs" />
+    <Compile Include="ConvenienceExtensions\SerializerExtensions.cs" />
     <Compile Include="ConvenienceExtensions\SourceExtensions.cs" />
     <Compile Include="ConvenienceExtensions\SourceManyExtensions.cs" />
     <Compile Include="Domain\Aggregations\AggregationsHelper.cs" />