Skip to content

Commit 2da2529

Browse files
committed
Decouple ScrollTests from number of shards and docs
1 parent 1dcd056 commit 2da2529

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/Tests/Nest.Tests.Integration/Search/Scroll/ScrollTests.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ public void SearchTypeScan()
2424
Assert.False(scanResults.FieldSelections.Any());
2525
Assert.IsNotNullOrEmpty(scanResults.ScrollId);
2626

27-
var scrolls = 0;
2827
var results = this.Client.Scroll<ElasticsearchProject>(s=>s
2928
.Scroll("4s")
3029
.ScrollId(scanResults.ScrollId)
3130
);
31+
var hitCount = results.Hits.Count();
3232
while (results.FieldSelections.Any())
3333
{
3434
Assert.True(results.IsValid);
@@ -38,9 +38,9 @@ public void SearchTypeScan()
3838
results = this.Client.Scroll<ElasticsearchProject>(s=>s
3939
.Scroll("4s")
4040
.ScrollId(localResults.ScrollId));
41-
scrolls++;
41+
hitCount += results.Hits.Count();
4242
}
43-
Assert.AreEqual(18, scrolls);
43+
Assert.AreEqual(scanResults.Total, hitCount);
4444
}
4545

4646
[Test]
@@ -58,21 +58,21 @@ public void SearchTypeScan_ObjectInitializer()
5858
Assert.False(scanResults.FieldSelections.Any());
5959
Assert.IsNotNullOrEmpty(scanResults.ScrollId);
6060

61-
var scrolls = 0;
6261
var results = this.Client.Scroll<ElasticsearchProject>(s=>s
6362
.Scroll("4s")
6463
.ScrollId(scanResults.ScrollId)
6564
);
65+
var hitCount = results.Hits.Count();
6666
while (results.FieldSelections.Any())
6767
{
6868
Assert.True(results.IsValid);
6969
Assert.True(results.FieldSelections.Any());
7070
Assert.IsNotNullOrEmpty(results.ScrollId);
7171
var localResults = results;
7272
results = this.Client.Scroll<ElasticsearchProject>(new ScrollRequest(localResults.ScrollId, "4s"));
73-
scrolls++;
73+
hitCount += results.Hits.Count();
7474
}
75-
Assert.AreEqual(18, scrolls);
75+
Assert.AreEqual(scanResults.Total, hitCount);
7676
}
7777

7878
[Test]
@@ -90,11 +90,11 @@ public void SearchTypeScanMoreThanOne()
9090
Assert.False(scanResults.FieldSelections.Any());
9191
Assert.IsNotNullOrEmpty(scanResults.ScrollId);
9292

93-
var scrolls = 0;
9493
var results = this.Client.Scroll<ElasticsearchProject>(s =>s
9594
.Scroll("4s")
9695
.ScrollId(scanResults.ScrollId));
97-
results.FieldSelections.Count().Should().Be(18);
96+
results.FieldSelections.Count().Should().Be((int)scanResults.Total);
97+
var hitCount = results.Hits.Count();
9898
while (results.FieldSelections.Any())
9999
{
100100
Assert.True(results.IsValid);
@@ -104,9 +104,9 @@ public void SearchTypeScanMoreThanOne()
104104
results = this.Client.Scroll<ElasticsearchProject>(s=>s
105105
.Scroll("4s")
106106
.ScrollId(results1.ScrollId));
107-
scrolls++;
107+
hitCount += results.Hits.Count();
108108
}
109-
Assert.AreEqual(1, scrolls);
109+
Assert.AreEqual(scanResults.Total, hitCount);
110110
}
111111
}
112112
}

0 commit comments

Comments
 (0)