renamed failover integration tests to better describe what they are doing, added an async test for sniff on fault integration test

Author: Mpdreamz

src/Tests/Nest.Tests.Integration/Failover/FailoverSniffOnFaultTests.cs

@@ -56,5 +56,46 @@ public void SniffOnFaultShouldGetCleanClusterState()
 
 		}
 
+		[Test]
+		public async void SniffOnFaultShouldGetCleanClusterState_Async()
+		{
+			var seeds = new[]
+			{
+				new Uri("http://localhost:9202"),
+				new Uri("http://localhost:9201"),
+				new Uri("http://localhost:9200"),
+			};
+			var sniffingConnectionPool = new SniffingConnectionPool(seeds, randomizeOnStartup: false);
+			var connectionSettings = new ConnectionSettings(sniffingConnectionPool)
+				.SniffOnConnectionFault();
+
+			var client = new ElasticClient(connectionSettings);
+			var rootNode = await client.RootNodeInfoAsync();
+			var metrics = rootNode.ConnectionStatus.Metrics;
+			
+			metrics.Requests.Count.Should().Be(5);
+			metrics.Requests[0].Node.Port.Should().Be(9202);
+			metrics.Requests[0].RequestType.Should().Be(RequestType.Ping);
+			metrics.Requests[1].Node.Port.Should().Be(9201);
+			metrics.Requests[1].RequestType.Should().Be(RequestType.Ping);
+			metrics.Requests[2].Node.Port.Should().Be(9200);
+			metrics.Requests[2].RequestType.Should().Be(RequestType.Ping);
+			metrics.Requests[3].Node.Port.Should().Be(9200);
+			metrics.Requests[3].RequestType.Should().Be(RequestType.Sniff);
+
+			metrics.Requests[4].Node.Port.Should().Be(9200);
+			metrics.Requests[4].RequestType.Should().Be(RequestType.ElasticsearchCall);
+
+
+			for (var i = 0; i < 3; i++)
+			{
+				rootNode = await client.RootNodeInfoAsync();
+				metrics = rootNode.ConnectionStatus.Metrics;
+				metrics.Requests.Count.Should().Be(1);
+				metrics.Requests[0].Node.Port.Should().Be(9200);
+				metrics.Requests[0].RequestType.Should().Be(RequestType.ElasticsearchCall);
+			}
+
+		}
 	}
 }

src/Tests/Nest.Tests.Integration/Failover/FailoverSniffOnStartupTests.cs

@@ -15,7 +15,7 @@ namespace Nest.Tests.Integration.Failover
 	public class FailoverSniffOnStartupTests
 	{
 		[Test]
-		public void FailoverShouldOnlyPingDeadNodes()
+		public void SniffOnStartShouldOnlyHit9200_WithoutPing()
 		{
 			var seeds = new[]
 			{
@@ -48,7 +48,7 @@ public void FailoverShouldOnlyPingDeadNodes()
 		}
 
 		[Test]
-		public async void FailoverShouldOnlyPingDeadNodes_Async()
+		public async void SniffOnStartShouldOnlyHit9200_WithoutPing_Async()
 		{
 			var seeds = new[]
 			{