Skip to content

Commit 532873a

Browse files
committed
client.execute() stays inside the try block
addresses #1197 (comment)
1 parent 38cc559 commit 532873a

File tree

1 file changed

+3
-3
lines changed
  • rest5-client/src/main/java/co/elastic/clients/transport/rest5_client/low_level

1 file changed

+3
-3
lines changed

rest5-client/src/main/java/co/elastic/clients/transport/rest5_client/low_level/Rest5Client.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,12 +298,12 @@ private Response performRequest(final Iterator<Node> nodes, final InternalReques
298298
throws IOException {
299299
RequestContext context = request.createContextForNextAttempt(nodes.next());
300300
ClassicHttpResponse httpResponse;
301-
Future<ClassicHttpResponse> future =
302-
client.execute(context.requestProducer, context.asyncResponseConsumer, context.context, null);
301+
Future<ClassicHttpResponse> future = null;
303302
try {
303+
future = client.execute(context.requestProducer, context.asyncResponseConsumer, context.context, null);
304304
httpResponse = future.get();
305305
} catch (Exception e) {
306-
future.cancel(true);
306+
if (future!=null) future.cancel(true);
307307
RequestLogger.logFailedRequest(logger, request.httpRequest, context.node, e);
308308
onFailure(context.node);
309309
Exception cause = extractAndWrapCause(e);

0 commit comments

Comments
 (0)