[Rule Tunings] GWS Rule Tunings (small changes)#6183
Open
imays11 wants to merge 1 commit into
Open
Conversation
Small changes to the following rules. All are performing as expected in telemetry, no major query changes needed. ### ALL - made index more specific `logs-google_workspace.admin*` - updated tags to include additional MITRE mapping - removed any unnecessary query filters, opting for only `data_stream.dataset` and `google_workspace.event.type` - added highlighted fields **I've kept the long `from` window to account for the 2 hour default lag time used by Filebeat, we've submitted a request to change this and will change our default rule settings when this changes.** ### External User Added to Google Workspace Group - changed the query to compare the shorter field `user.target.domain` vs the longer field `user.target.email`. Essentially the same comparison is being made just with a smaller field. Screenshot below shows the still working query. Tested all the Rules manually, test data is in our shared stack.
Contributor
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Small changes to the following rules. All are performing as expected in telemetry, no major query changes needed.
ALL
logs-google_workspace.admin-*data_stream.datasetandgoogle_workspace.event.typeI've kept the long
fromwindow to account for the 2 hour default lag time used by Filebeat, we've submitted an Integrations request to change this.External User Added to Google Workspace Group
user.target.domainvs the longer fielduser.target.email. Essentially the same comparison is being made just with a smaller field. Screenshot below shows the still working query.How To Test
Tested all the Rules manually, test data is in our shared stack.