Skip to content

fix: add sessions empty state guidance#9

Merged
ek33450505 merged 1 commit into
ek33450505:mainfrom
GodHad:fix-sessions-empty-copy-8
May 14, 2026
Merged

fix: add sessions empty state guidance#9
ek33450505 merged 1 commit into
ek33450505:mainfrom
GodHad:fix-sessions-empty-copy-8

Conversation

@GodHad
Copy link
Copy Markdown
Contributor

@GodHad GodHad commented May 10, 2026

Description

Adds clearer empty-state guidance to the Sessions page when no session data exists. The non-search/non-filter empty state now keeps the existing “No sessions found” heading and adds guidance telling users to run claude to start a session.

Search/filter empty states still show “No matching sessions” unchanged.

Closes #8

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • Tests pass locally (npm test)
  • TypeScript build is clean (npx tsc --noEmit)
  • No new console errors or warnings in the browser
  • Responsive layout checked at multiple viewport sizes
  • README updated if this PR adds or changes a user-facing feature

@ek33450505 ek33450505 merged commit 3669f64 into ek33450505:main May 14, 2026
1 check passed
@ek33450505
Copy link
Copy Markdown
Owner

Thanks for the clean PR, @GodHad — really appreciate this being your first contribution to the repo. You hit the spec exactly: caught both empty-state render paths (table + virtualized), used the --text-primary theme token, and the DRY extraction into emptySessionCopy is the right call. Diff stayed surgical too — no scope creep, no formatting churn.

Approving and merging now. Hope you'll send more — the dashboard has a few more good first issue tagged tickets if you want another swing.

@GodHad GodHad deleted the fix-sessions-empty-copy-8 branch May 14, 2026 16:20
@GodHad
Copy link
Copy Markdown
Contributor Author

GodHad commented May 14, 2026

Thank you for the thoughtful review and for merging it. I appreciate the clear issue write-up — it made it easy to keep the change focused.

I’ll keep an eye on the good first issue tickets and would be happy to take another swing where I can help. Glad to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add empty-state copy to the Sessions page when no data exists

2 participants