fix(core): address PR review feedback

- Validate typescriptEnabled in manifest #validate() to reject stale
  TS/JS resolution caches when TypeScript mode changes
- Fix globFiles() empty array bug: `if (cached)` treated [] as falsy
- Fix triggerLoadMetadata() to propagate first error via this.ready(err)
- Fix clean() to only ignore ENOENT, rethrow other errors
- Use import.meta.url instead of __dirname in ESM test

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: killagu

packages/core/src/lifecycle.ts

@@ -345,19 +345,22 @@ export class Lifecycle extends EventEmitter {
   async triggerLoadMetadata(): Promise<void> {
     this.#metadataOnly = true;
     debug('trigger loadMetadata start');
+    let firstError: Error | undefined;
     for (const boot of this.#boots) {
       if (typeof boot.loadMetadata === 'function') {
         debug('trigger loadMetadata at %o', boot.fullPath);
         try {
           await boot.loadMetadata();
         } catch (err) {
-          debug('trigger loadMetadata error at %o, error: %s', boot.fullPath, err);
-          this.emit('error', err);
+          const error = err instanceof Error ? err : new Error(String(err));
+          if (!firstError) firstError = error;
+          debug('trigger loadMetadata error at %o, error: %s', boot.fullPath, error);
+          this.emit('error', error);
         }
       }
     }
     debug('trigger loadMetadata end');
-    this.ready(true);
+    this.ready(firstError ?? true);
   }
 
   #initReady(): void {

packages/core/src/loader/manifest.ts

@@ -4,6 +4,8 @@ import fsp from 'node:fs/promises';
 import path from 'node:path';
 import { debuglog } from 'node:util';
 
+import { isSupportTypeScript } from '@eggjs/utils';
+
 const debug = debuglog('egg/core/loader/manifest');
 
 const MANIFEST_VERSION = 1;
@@ -124,6 +126,16 @@ export class ManifestStore {
       return false;
     }
 
+    const currentTypescriptEnabled = isSupportTypeScript();
+    if (inv.typescriptEnabled !== currentTypescriptEnabled) {
+      debug(
+        'manifest typescriptEnabled mismatch: expected %s, got %s',
+        currentTypescriptEnabled,
+        inv.typescriptEnabled,
+      );
+      return false;
+    }
+
     const currentLockfileFingerprint = ManifestStore.#lockfileFingerprint(baseDir);
     if (inv.lockfileFingerprint !== currentLockfileFingerprint) {
       debug('manifest lockfileFingerprint mismatch');
@@ -163,8 +175,9 @@ export class ManifestStore {
    */
   globFiles(directory: string, fallback: () => string[]): string[] {
     const relKey = this.#toRelative(directory);
-    const cached = this.data.fileDiscovery?.[relKey];
-    if (cached) {
+    const cache = this.data.fileDiscovery;
+    if (cache && relKey in cache) {
+      const cached = cache[relKey];
       debug('[globFiles:manifest] using cached files for %o, count: %d', directory, cached.length);
       return cached;
     }
@@ -216,8 +229,8 @@ export class ManifestStore {
     try {
       fs.unlinkSync(manifestPath);
       debug('manifest removed: %s', manifestPath);
-    } catch {
-      // file doesn't exist, nothing to do
+    } catch (err: any) {
+      if (err.code !== 'ENOENT') throw err;
     }
   }
 

packages/core/test/loader/manifest_roundtrip.test.ts

@@ -1,6 +1,7 @@
 import assert from 'node:assert/strict';
 import fs from 'node:fs';
 import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 
 import { describe, it, beforeEach, afterEach } from 'vitest';
 
@@ -99,7 +100,8 @@ describe('ManifestStore roundtrip: generate → write → load', () => {
   });
 
   it('should match expected manifest fixture structure', () => {
-    const fixturePath = path.join(__dirname, '../fixtures/manifest/expected-manifest.json');
+    const currentDir = path.dirname(fileURLToPath(import.meta.url));
+    const fixturePath = path.join(currentDir, '../fixtures/manifest/expected-manifest.json');
     const expected = JSON.parse(fs.readFileSync(fixturePath, 'utf-8'));
 
     assert.equal(expected.version, 1);