Skip to content

Commit a7d78fe

Browse files
authored
2.3.0 Working on looser groovy 3 version requirements (#20)
* pom.xml * Bumped to 2.3.0 * Switched to using groovy-all as provided * Added explicit depenency on groovy-json * Switched to using loose groovy versioning [3.0,4.0) * Cleaned up no longer used profiles * Updated github action to only build one jar
1 parent b17b7fc commit a7d78fe

File tree

5 files changed

+18
-38
lines changed

5 files changed

+18
-38
lines changed

.github/workflows/publish-maven-package.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,9 @@ jobs:
4141
4242
mkdir -p repository/com/eficode/devstack
4343
44-
mvn help:effective-pom -P groovy-3,groovy-3.0.14 -Doutput=effective-pom.xml
44+
mvn help:effective-pom -P groovy-3 -Doutput=effective-pom.xml
4545
mvn install -f effective-pom.xml -DcreateChecksum=true
4646
47-
mvn help:effective-pom -P groovy-3,groovy-3.0.13 -Doutput=effective-pom.xml
48-
mvn install -f effective-pom.xml -DcreateChecksum=true
49-
50-
mvn help:effective-pom -P groovy-3,groovy-3.0.12 -Doutput=effective-pom.xml
51-
mvn install -f effective-pom.xml -DcreateChecksum=true
52-
53-
mvn help:effective-pom -P groovy-3,groovy-3.0.11 -Doutput=effective-pom.xml
54-
mvn install -f effective-pom.xml -DcreateChecksum=true
5547
5648
- name: Copying JAR files
5749
run: |

pom.xml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>com.eficode</groupId>
88
<artifactId>devstack</artifactId>
9-
<version>2.2.4-SNAPSHOT-groovy-${groovy.version}</version>
9+
<version>2.3.0-SNAPSHOT</version>
1010
<packaging>jar</packaging>
1111

1212
<name>DevStack</name>
@@ -23,12 +23,17 @@
2323
<groupId>org.codehaus.groovy</groupId>
2424
<artifactId>groovy-all</artifactId>
2525
<version>${groovy.version}</version>
26+
<scope>provided</scope>
2627
<type>pom</type>
2728
</dependency>
2829
<dependency>
2930
<groupId>org.codehaus.groovy</groupId>
3031
<artifactId>groovy-yaml</artifactId>
31-
<!--version>3.0.11</version-->
32+
<version>${groovy.version}</version>
33+
</dependency>
34+
<dependency>
35+
<groupId>org.codehaus.groovy</groupId>
36+
<artifactId>groovy-json</artifactId>
3237
<version>${groovy.version}</version>
3338
</dependency>
3439
<!-- https://mvnrepository.com/artifact/org.codehaus.groovy/groovy-ant -->
@@ -271,32 +276,14 @@
271276
<maven.compiler.source>11</maven.compiler.source>
272277
<maven.compiler.target>11</maven.compiler.target>
273278
<groovy.major.version>3.0</groovy.major.version>
274-
<groovy.version>3.0.14</groovy.version>
275-
<spock-core.version>2.2-groovy-3.0</spock-core.version>
279+
<groovy.version>[3.0,4.0)</groovy.version>
280+
<spock-core.version>2.4-M1-groovy-${groovy.major.version}</spock-core.version>
276281
<jiraShortcuts.version>2.0.3-SNAPSHOT-groovy-3.0</jiraShortcuts.version>
277282
<bitbucketinstancemanager.version>0.0.3-SNAPSHOT-groovy-3.0</bitbucketinstancemanager.version>
278283
</properties>
279284
</profile>
280285

281286

282-
<profile>
283-
<id>groovy-3.0.14</id>
284-
<properties>
285-
<groovy.version>3.0.13</groovy.version>
286-
</properties>
287-
</profile>
288-
<profile>
289-
<id>groovy-3.0.12</id>
290-
<properties>
291-
<groovy.version>3.0.12</groovy.version>
292-
</properties>
293-
</profile>
294-
<profile>
295-
<id>groovy-3.0.11</id>
296-
<properties>
297-
<groovy.version>3.0.11</groovy.version>
298-
</properties>
299-
</profile>
300287

301288
</profiles>
302289

src/test/groovy/com/eficode/devstack/deployment/impl/BitbucketH2DeploymentTest.groovy

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ class BitbucketH2DeploymentTest extends DevStackSpec{
1919
def setupSpec() {
2020

2121

22-
dockerRemoteHost = "https://docker.domain.se:2376"
23-
dockerCertPath = "~/.docker/"
22+
//dockerRemoteHost = "https://docker.domain.se:2376"
23+
//dockerCertPath = "~/.docker/"
24+
2425

2526

2627
log = LoggerFactory.getLogger(BitbucketH2DeploymentTest.class)

src/test/groovy/com/eficode/devstack/deployment/impl/HarborDeploymentTest.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import org.slf4j.LoggerFactory
1010
class HarborDeploymentTest extends DevStackSpec {
1111
def setupSpec() {
1212

13-
dockerRemoteHost = "https://docker.domain.se:2376"
14-
dockerCertPath = "~/.docker/"
13+
//dockerRemoteHost = "https://docker.domain.se:2376"
14+
//dockerCertPath = "~/.docker/"
1515

1616

1717
log = LoggerFactory.getLogger(HarborDeploymentTest.class)
@@ -87,7 +87,7 @@ class HarborDeploymentTest extends DevStackSpec {
8787
where:
8888
dockerHost | certPath | harborBaseUrl | harborVersion | harborBaseDir
8989
"" | "" | "http://localhost" | "v2.6.0" | "/tmp"
90-
//dockerRemoteHost | dockerCertPath | "http://harbor.domain.se" | "v2.6.0" | "/tmp"
90+
dockerRemoteHost | dockerCertPath | "http://harbor.domain.se" | "v2.6.0" | "/tmp"
9191

9292
}
9393
}

src/test/groovy/com/eficode/devstack/deployment/impl/JsmH2DeploymentTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ class JsmH2DeploymentTest extends DevStackSpec {
1515

1616
def setupSpec() {
1717

18-
dockerRemoteHost = "https://docker.domain.se:2376"
19-
dockerCertPath = "~/.docker/"
18+
//dockerRemoteHost = "https://docker.domain.se:2376"
19+
//dockerCertPath = "~/.docker/"
2020

2121

2222
log = LoggerFactory.getLogger(JsmH2DeploymentTest.class)

0 commit comments

Comments
 (0)