test: extend tests for cli, config, hooks

- Add CLI integration test for dry-run commit
- Update config test to validate malformed hooks
- Add openai-client test for isReasoningModel

extends the test suite to cover CLI integration, config validation, hook
error handling, and reasoning model detection in the OpenAI client

Co-Authored-By: Git Agent <noreply@git-agent.dev>

Author: xesrevinu

tests/cli-integration.test.ts

@@ -478,6 +478,53 @@ describe.concurrent("CLI integration", () => {
       }),
     );
 
+    it.effect(
+      "git commit --dry-run does not persist auto-generated scopes",
+      Effect.fn(function* () {
+        const repo = yield* seedGitRepo();
+        yield* writeTextFile(repo, "api/routes.ts", "export const route = 'v2';\n");
+
+        const llm = yield* startMockLlmServer([
+          {
+            content: {
+              scopes: [{ name: "api", description: "Backend API handlers" }],
+            },
+          },
+          {
+            content: {
+              scopes: [{ name: "api", description: "Backend API handlers" }],
+            },
+          },
+          {
+            content: {
+              title: "feat(api): update routes",
+              bullets: ["Adjust API routing output"],
+              explanation: "Updates the API route response shape.",
+            },
+          },
+        ]);
+
+        const result = yield* runCli(
+          [
+            "commit",
+            "--dry-run",
+            "--api-key",
+            "test-key",
+            "--base-url",
+            llm.baseUrl,
+            "--model",
+            "test-model",
+          ],
+          { cwd: repo },
+        );
+
+        expect(result.exitCode).toBe(0);
+        expect(result.stdout).toContain("feat(api): update routes");
+        expect(yield* fileExists(repo, ".git-agent/config.yml")).toBe(false);
+        expect(llm.requests).toHaveLength(3);
+      }),
+    );
+
     it.effect(
       "git commit creates split commits that match the planner groups",
       Effect.fn(function* () {

tests/config.test.ts

@@ -1,5 +1,25 @@
-import { describe, expect, it } from "vitest";
+import { NodeServices } from "@effect/platform-node";
+import { Effect } from "effect";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, describe, expect, it } from "vitest";
 import { defaultScopeForKey, normalizeValue, resolveKey } from "../src/config/keys";
+import { loadProjectConfig } from "../src/config/project";
+
+const tempDirs: Array<string> = [];
+
+const runEffect = <A>(effect: Effect.Effect<A, unknown, any>) =>
+  Effect.runPromise(Effect.provide(effect, NodeServices.layer) as Effect.Effect<A, unknown, never>);
+
+afterEach(() => {
+  while (tempDirs.length > 0) {
+    const dir = tempDirs.pop();
+    if (dir != null) {
+      rmSync(dir, { recursive: true, force: true });
+    }
+  }
+});
 
 describe("config keys", () => {
   it("normalizes kebab-case aliases", () => {
@@ -15,4 +35,18 @@ describe("config keys", () => {
   it("normalizes slice values", () => {
     expect(normalizeValue("hook", "conventional, empty")).toBe("conventional,empty");
   });
+
+  it("fails when project config contains malformed hook values", async () => {
+    const repoRoot = mkdtempSync(join(tmpdir(), "git-agent-config-"));
+    tempDirs.push(repoRoot);
+    mkdirSync(join(repoRoot, ".git-agent"), { recursive: true });
+    writeFileSync(join(repoRoot, ".git-agent", "config.yml"), "hook: 123\n");
+
+    await expect(runEffect(loadProjectConfig(repoRoot))).rejects.toMatchObject({
+      message: expect.stringContaining("invalid config"),
+    });
+    await expect(runEffect(loadProjectConfig(repoRoot))).rejects.toMatchObject({
+      message: expect.stringContaining("hook"),
+    });
+  });
 });

tests/hooks.test.ts

@@ -36,14 +36,13 @@ afterEach(() => {
 });
 
 describe("executeHooks", () => {
-  it("skips missing shell hooks like the Go version", async () => {
+  it("fails when a configured shell hook is missing", async () => {
     const dir = mkdtempSync(join(tmpdir(), "git-agent-hooks-"));
     tempDirs.push(dir);
+    const hookPath = join(dir, "missing-hook.sh");
 
-    const result = await runEffect(executeHooks([join(dir, "missing-hook.sh")], hookInput));
-    expect(result).toEqual({
-      exitCode: 0,
-      stderr: "",
+    await expect(runEffect(executeHooks([hookPath], hookInput))).rejects.toMatchObject({
+      message: expect.stringContaining(`failed to read hook "${hookPath}"`),
     });
   });
 

tests/openai-client.test.ts

@@ -0,0 +1,26 @@
+import { describe, expect, it } from "vitest";
+import { isReasoningModel } from "../src/services/openai-client";
+
+describe("isReasoningModel", () => {
+  it("accepts current reasoning model families", () => {
+    expect(isReasoningModel("o1")).toBe(true);
+    expect(isReasoningModel("o3-mini")).toBe(true);
+    expect(isReasoningModel("o4-mini")).toBe(true);
+    expect(isReasoningModel("codex-mini-latest")).toBe(true);
+    expect(isReasoningModel("computer-use-preview")).toBe(true);
+    expect(isReasoningModel("gpt-5")).toBe(true);
+    expect(isReasoningModel("gpt-5-mini")).toBe(true);
+  });
+
+  it("rejects non-reasoning models", () => {
+    expect(isReasoningModel("gpt-4o-mini")).toBe(false);
+    expect(isReasoningModel("gpt-5-chat-latest")).toBe(false);
+    expect(isReasoningModel("claude-sonnet-4")).toBe(false);
+  });
+
+  it("handles provider-prefixed model ids", () => {
+    expect(isReasoningModel("openai/gpt-5")).toBe(true);
+    expect(isReasoningModel("openrouter/openai/o4-mini")).toBe(true);
+    expect(isReasoningModel("openai/gpt-5-chat-latest")).toBe(false);
+  });
+});