Added edge case tests

Author: shorodilov

tests/bisearch/conftest.py

@@ -4,12 +4,12 @@
 
 
 @pytest.fixture
-def strings_small():
+def strings_small_fixture():
     return sorted(["a", "b", "c", "ab", "bc", "ca", "abc", "bca", "cab"])
 
 
 @pytest.fixture
-def strings_large():
+def strings_large_fixture():
     # 10_000 strings generated with https://random.org
     fixture_path = Path(__file__).parent.joinpath("fixtures/strings.txt")
     with open(fixture_path) as fixture_file:

tests/bisearch/test_prefix.py

@@ -4,42 +4,53 @@
 from bisearch.prefix import NotFound
 
 
-def test_prefix_right(strings_large, prefix_right_fixture):
+def test_prefix_right(strings_large_fixture, prefix_right_fixture):
     search, test_value = prefix_right_fixture
-    assert prefix.bisect_right(strings_large, search) == test_value
+    assert prefix.bisect_right(strings_large_fixture, search) == test_value
 
 
-def test_prefix_left(strings_large, prefix_left_fixture):
+def test_prefix_left(strings_large_fixture, prefix_left_fixture):
     search, test_value = prefix_left_fixture
-    assert prefix.bisect_left(strings_large, search) == test_value
+    assert prefix.bisect_left(strings_large_fixture, search) == test_value
 
 
-def test_find_all(strings_large, find_all_fixture):
+def test_find_all(strings_large_fixture, find_all_fixture):
     search, test_value = find_all_fixture
-    assert prefix.find_all(strings_large, search) == test_value
+    assert prefix.find_all(strings_large_fixture, search) == test_value
 
 
-def test_prefix_right_default(strings_small):
-    assert prefix.bisect_right(strings_small) == len(strings_small)
+def test_prefix_right_default(strings_small_fixture):
+    string_idx = len(strings_small_fixture)
+    assert prefix.bisect_right(strings_small_fixture) == string_idx
 
 
-def test_prefix_left_default(strings_small):
-    assert prefix.bisect_left(strings_small) == 0
+def test_prefix_left_default(strings_small_fixture):
+    assert prefix.bisect_left(strings_small_fixture) == 0
 
 
-def test_find_all_default(strings_small):
-    assert prefix.find_all(strings_small) == strings_small
+def test_find_all_default(strings_small_fixture):
+    assert prefix.find_all(strings_small_fixture) == strings_small_fixture
 
 
-def test_prefix_right_negative(strings_small):
+def test_prefix_right_last(strings_small_fixture):
+    string_idx = len(strings_small_fixture)
+    assert prefix.bisect_right(strings_small_fixture, "cab") == string_idx
+
+
+def test_prefix_left_last(strings_small_fixture):
+    string_idx = len(strings_small_fixture) - 1
+    assert prefix.bisect_left(strings_small_fixture, "cab") == string_idx
+
+
+def test_prefix_right_negative(strings_small_fixture):
     with pytest.raises(NotFound):
-        prefix.bisect_right(strings_small, "d")
+        prefix.bisect_right(strings_small_fixture, "d")
 
 
-def test_prefix_left_negative(strings_small):
+def test_prefix_left_negative(strings_small_fixture):
     with pytest.raises(NotFound):
-        prefix.bisect_left(strings_small, "d")
+        prefix.bisect_left(strings_small_fixture, "d")
 
 
-def test_find_all_negative(strings_small):
-    assert prefix.find_all(strings_small, "d") == []
+def test_find_all_negative(strings_small_fixture):
+    assert prefix.find_all(strings_small_fixture, "d") == []