[BUG] - Navigation behavior

[pca006132]

Describe the bug

The tabs on the bottom navigation bars are not remembered.

Not sure what is the correct terminology, but see the reproduce part below.

Expected behavior

It should remember that.

To Reproduce

1. Click on the Library tab on the bottom navigation bar.
2. Click on an album.
3. Click on the Download tab on the bottom navigation bar.
4. Click on the Library tab on the bottom navigation bar.

After step 4, I will expect this switch back to the album page. However, this switches to the library home page.

Environment

• Android device: Xiaomi POCO X3 Pro
• Android OS version: 12
• App version: 4.0.7
• App variant: both variants
• Other relevant details: [e.g., specific network conditions, external dependencies]

Logs or Screenshots

Additional context

This is only slightly annoying to me, and not sure if this is expected or a bad UX. One problem is that this may cause increased memory usage when users perform complex UI navigations.

That said, maybe we should do other things to reduce memory usage instead, e.g. more pagination and unload unused data?

[tvillega]

I can confirm this is the expected behavior. The navbar buttons Home, Library and Download are just shortcuts, all the pages we see in the app are equally treated on the navigation. See #460.

Your expected navigation requires a homeNavigationController, libraryNavigationController and downloadNavigationController for the respective fragment, and on top of that a globalNavigationController that keeps the back-stack for Home, Library, Download and Settings (which is also a fragment). I'm not sure how that would handle the back-button, since there are two navigations active, but Settings does need to catch it or else it traps you inside.

I feel there is little gain from it because Home and Library can access the same set of fragments. This app is quite simple and powerful, I think that is what the user base looks from the app.