Dummy sets_stats_df if sets is not None but is empty#1
Open
JoeRibeiro wants to merge 1 commit into
Open
Conversation
Collaborator
|
I think the key here is that the test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jiho
Amy & I at Cefas tested on a file with no defined sets and the converted_data.json came out containing:
"set_information": {
"definition": "",
"statistics": []
},
It tripped up causing the error:
Error processing 'converted_data.json': cannot access local variable 'sets_stats_df' where it is not associated with a value
Because set_information was present as an empty dictionary (not none) and sets_stats_df is only created inside the loop over set_information["statistics"]
This small fix seemed to unstick things. Cheers,
Joe