From 5db8945def510bcc32ab2dc9bd6f85d441afc878 Mon Sep 17 00:00:00 2001 From: Matthew Griffith <93525584+mjg41@users.noreply.github.com> Date: Fri, 6 Mar 2026 17:22:34 +0000 Subject: [PATCH 1/4] ADR-004: Introducing model keyword for DestinE DE330 On-Demand Extremes DT. --- ADR/ADR-004-ODEDT-model-keyword.md | 90 ++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 ADR/ADR-004-ODEDT-model-keyword.md diff --git a/ADR/ADR-004-ODEDT-model-keyword.md b/ADR/ADR-004-ODEDT-model-keyword.md new file mode 100644 index 0000000..e08477d --- /dev/null +++ b/ADR/ADR-004-ODEDT-model-keyword.md @@ -0,0 +1,90 @@ +# ADR-004: Model keyword for DE330 (ODEDT) + +# Status + +Proposed + +# Last Updated + +06.03.2026 + +# Context + +### Background + +The on-demand-extremes-dt routinely runs multiple models covering the same period, such as different NWP models (ALARO, AROME, HARMONIE-AROME) as well as several impact models (AQ, Hydrology, renewables, wildfire etc.). + +Thus, an additional axis is needed to cope with several models running with all other mars metadata identical. To this end we would introduce the model keyword to the on-demand-extremes-dt data index, as has been introduced in other datasets such as class=ai. We would add the model keyword in the same way here. + +Values in ecCodes are currently as follows, but would be extended as the impact models become known and well formed ( `localConcepts/destine/modelNameConcept` ): + +- IFS +- AIFS +- ICON +- ALARO +- AROME +- HARMONIE-AROME +- \ (to be updated with value from DE330) +- \ (to be updated with value from DE330) +- \ (to be updated with value from DE330) +- … + +### MARS archiving approach + +MARS namespace: + +
{
+  "messages": [
+    {
+      "date": 20260211,
+      "time": 1200,
+      "expver": "0001",
+      "class": "d1",
+      "dataset": "on-demand-extremes-dt",
+      "georef": "u23er4",
+      "type": "fc",
+      "stream": "oper",
+      "step": 6,
+      "levtype": "sfc",
+      "model": "HARMONIE-AROME",
+      "timespan": "none",
+      "param": 167
+    }
+  ]
+}
+
+ +# Options Considered + +### 1. Include model key + +We believe this key is necessary to index data coming from different models within the on-demand Extremes DT project. + +# Analysis + +Prototype at: [text](https://github.com/ecmwf/eccodes/tree/feature/ECC-2222-model-for-de330) + +# Decision + +Meeting was held on 06/03/2026 to discuss the proposal with: + +- Simon Smart +- Emanuele Danovaro +- Seb Villaume +- Robert Osinski +- Bojan Kasic + +Everyone was happy with the proposal. We will proceed with the implementation. + +# Consequences + +- ecCodes development to add model keyword to indexing namespace for on-demand-extremes-dt data +- metkit development to add new values of model keyword to language file. + +# References + +# Authors + +- Matthew Griffith +- Sebastien Villaume +- Robert Osinski From 05315a9993a9efa2333fb353537a8173bd64eec1 Mon Sep 17 00:00:00 2001 From: Matthew Griffith Date: Wed, 11 Mar 2026 11:24:16 +0000 Subject: [PATCH 2/4] Updated following Simon's comments and additional meeting with Paul who approved the proposal. --- ...-004-ODEDT-model-keyword.md => ADR-005-ODEDT-model-keyword.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename ADR/{ADR-004-ODEDT-model-keyword.md => ADR-005-ODEDT-model-keyword.md} (100%) diff --git a/ADR/ADR-004-ODEDT-model-keyword.md b/ADR/ADR-005-ODEDT-model-keyword.md similarity index 100% rename from ADR/ADR-004-ODEDT-model-keyword.md rename to ADR/ADR-005-ODEDT-model-keyword.md From aec82d1f7b1694a53173a19836f68fddcc3e998d Mon Sep 17 00:00:00 2001 From: Matthew Griffith Date: Wed, 11 Mar 2026 11:24:16 +0000 Subject: [PATCH 3/4] Updated to ADR-005 as ADR-004 is already in use. --- ...del-keyword.md => ADR-005-ODEDT-model-keyword.md} | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) rename ADR/{ADR-004-ODEDT-model-keyword.md => ADR-005-ODEDT-model-keyword.md} (83%) diff --git a/ADR/ADR-004-ODEDT-model-keyword.md b/ADR/ADR-005-ODEDT-model-keyword.md similarity index 83% rename from ADR/ADR-004-ODEDT-model-keyword.md rename to ADR/ADR-005-ODEDT-model-keyword.md index e08477d..f1b70db 100644 --- a/ADR/ADR-004-ODEDT-model-keyword.md +++ b/ADR/ADR-005-ODEDT-model-keyword.md @@ -1,4 +1,4 @@ -# ADR-004: Model keyword for DE330 (ODEDT) +# ADR-005: Model keyword for DE330 (ODEDT) # Status @@ -6,7 +6,7 @@ Proposed # Last Updated -06.03.2026 +10.03.2026 # Context @@ -62,7 +62,8 @@ We believe this key is necessary to index data coming from different models with # Analysis -Prototype at: [text](https://github.com/ecmwf/eccodes/tree/feature/ECC-2222-model-for-de330) +- Prototype at: [text](https://github.com/ecmwf/eccodes/tree/feature/ECC-2222-model-for-de330) +- This has been introduced in other datasets such as class=ai. We would add the model keyword in the same way here. Thus this represents a consistent approach in-line with other datasets. # Decision @@ -74,6 +75,11 @@ Meeting was held on 06/03/2026 to discuss the proposal with: - Robert Osinski - Bojan Kasic +Following up meeting to confirm with User Services with: + +- Paul Dando +- Bojan Kasic + Everyone was happy with the proposal. We will proceed with the implementation. # Consequences From 87b6dcd01658f6629fc4dfdbdf9099f62aaa2c03 Mon Sep 17 00:00:00 2001 From: Matthew Griffith Date: Wed, 11 Mar 2026 11:29:41 +0000 Subject: [PATCH 4/4] Update text in background section. --- ADR/ADR-005-ODEDT-model-keyword.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ADR/ADR-005-ODEDT-model-keyword.md b/ADR/ADR-005-ODEDT-model-keyword.md index f1b70db..f9381ce 100644 --- a/ADR/ADR-005-ODEDT-model-keyword.md +++ b/ADR/ADR-005-ODEDT-model-keyword.md @@ -14,7 +14,7 @@ Proposed The on-demand-extremes-dt routinely runs multiple models covering the same period, such as different NWP models (ALARO, AROME, HARMONIE-AROME) as well as several impact models (AQ, Hydrology, renewables, wildfire etc.). -Thus, an additional axis is needed to cope with several models running with all other mars metadata identical. To this end we would introduce the model keyword to the on-demand-extremes-dt data index, as has been introduced in other datasets such as class=ai. We would add the model keyword in the same way here. +Thus, an additional axis is needed to cope with several models running with all other mars metadata identical. To this end we would introduce the model keyword to the on-demand-extremes-dt data index, as has been introduced in other datasets and contexts such as class=ai. We would add the model keyword in the same way here. Thus this represents a consistent approach in-line with other datasets. Values in ecCodes are currently as follows, but would be extended as the impact models become known and well formed ( `localConcepts/destine/modelNameConcept` ):