From 48bd93abcaea12b79768fffa3585dafcabd50e25 Mon Sep 17 00:00:00 2001 From: Patrick Ziegler Date: Wed, 8 Apr 2026 20:05:32 +0200 Subject: [PATCH] Fix ConcurrentModifcationException in MenuObjectEditPart The edit-part registry of a viewer might change when refreshing an edit-part. To avoid this, use a copy of all edit-parts. Seen in MenuComplexTest.test_CREATE_popup_newItem_deep --- .../wb/internal/core/gef/part/menu/MenuObjectEditPart.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java b/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java index fe992770d..ee68e0465 100644 --- a/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java +++ b/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java @@ -205,7 +205,7 @@ public EditPart getTargetEditPart(Request request) { public void run() { try { MenuObjectInfoUtils.m_selectingObject = m_object; - for (EditPart editPart : getViewer().getEditPartRegistry().values()) { + for (EditPart editPart : List.copyOf(getViewer().getEditPartRegistry().values())) { if (editPart instanceof MenuObjectEditPart) { editPart.refresh(); }