Skip to content

Commit cb726d9

Browse files
committed
Fix ConcurrentModifcationException in MenuObjectEditPart
The edit-part registry of a viewer might change when refreshing an edit-part. To avoid this, use a copy of all edit-parts. Seen in MenuComplexTest.test_CREATE_popup_newItem_deep
1 parent 682778f commit cb726d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ public EditPart getTargetEditPart(Request request) {
205205
public void run() {
206206
try {
207207
MenuObjectInfoUtils.m_selectingObject = m_object;
208-
for (EditPart editPart : getViewer().getEditPartRegistry().values()) {
208+
for (EditPart editPart : List.copyOf(getViewer().getEditPartRegistry().values())) {
209209
if (editPart instanceof MenuObjectEditPart) {
210210
editPart.refresh();
211211
}

0 commit comments

Comments
 (0)