Skip to content

Commit 2b6b4b0

Browse files
committed
[GEF] Deprecate ChangeBoundsRequest for removal
This replaces all references to our class with the GEF request. Methods using this class have either been removed or deprecated, for binary compatibility.
1 parent 749b524 commit 2b6b4b0

File tree

80 files changed

+202
-299
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+202
-299
lines changed

org.eclipse.wb.core.java/src/org/eclipse/wb/core/gef/policy/selection/TopSelectionEditPolicy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import org.eclipse.wb.core.model.IAbstractComponentInfo;
1818
import org.eclipse.wb.core.model.ITopBoundsSupport;
1919
import org.eclipse.wb.draw2d.FigureUtils;
20-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
2120
import org.eclipse.wb.gef.graphical.handles.Handle;
2221
import org.eclipse.wb.gef.graphical.handles.MoveHandle;
2322
import org.eclipse.wb.gef.graphical.handles.ResizeHandle;
@@ -29,6 +28,7 @@
2928
import org.eclipse.draw2d.geometry.Rectangle;
3029
import org.eclipse.gef.Request;
3130
import org.eclipse.gef.commands.Command;
31+
import org.eclipse.gef.requests.ChangeBoundsRequest;
3232

3333
import java.util.ArrayList;
3434
import java.util.List;

org.eclipse.wb.core.java/src/org/eclipse/wb/internal/core/gef/policy/nonvisual/NonVisualLayoutEditPolicy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import org.eclipse.wb.core.gef.policy.PolicyUtils;
1717
import org.eclipse.wb.core.model.JavaInfo;
1818
import org.eclipse.wb.gef.core.policies.ILayoutRequestValidator;
19-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
2019
import org.eclipse.wb.gef.core.requests.CreateRequest;
2120
import org.eclipse.wb.gef.core.requests.PasteRequest;
2221
import org.eclipse.wb.gef.graphical.policies.LayoutEditPolicy;
@@ -36,6 +35,7 @@
3635
import org.eclipse.gef.Request;
3736
import org.eclipse.gef.RequestConstants;
3837
import org.eclipse.gef.commands.Command;
38+
import org.eclipse.gef.requests.ChangeBoundsRequest;
3939

4040
import org.apache.commons.lang3.ClassUtils;
4141

org.eclipse.wb.core.java/src/org/eclipse/wb/internal/core/gef/policy/nonvisual/NonVisualValidator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2011, 2024 Google, Inc. and others.
2+
* Copyright (c) 2011, 2026 Google, Inc. and others.
33
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License 2.0 which is available at
@@ -14,7 +14,6 @@
1414

1515
import org.eclipse.wb.core.model.JavaInfo;
1616
import org.eclipse.wb.gef.core.policies.ILayoutRequestValidator;
17-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
1817
import org.eclipse.wb.gef.core.requests.CreateRequest;
1918
import org.eclipse.wb.gef.core.requests.PasteRequest;
2019
import org.eclipse.wb.internal.core.DesignerPlugin;
@@ -26,6 +25,7 @@
2625
import org.eclipse.wb.internal.core.utils.execution.ExecutionUtils;
2726

2827
import org.eclipse.gef.EditPart;
28+
import org.eclipse.gef.requests.ChangeBoundsRequest;
2929

3030
import org.apache.commons.lang3.StringUtils;
3131

org.eclipse.wb.core.java/src/org/eclipse/wb/internal/core/gefTree/policy/ArrayObjectRequestValidator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2011, 2024 Google, Inc. and others.
2+
* Copyright (c) 2011, 2026 Google, Inc. and others.
33
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License 2.0 which is available at
@@ -14,7 +14,6 @@
1414

1515
import org.eclipse.wb.core.model.JavaInfo;
1616
import org.eclipse.wb.gef.core.policies.ILayoutRequestValidator;
17-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
1817
import org.eclipse.wb.gef.core.requests.CreateRequest;
1918
import org.eclipse.wb.gef.core.requests.PasteRequest;
2019
import org.eclipse.wb.internal.core.model.nonvisual.AbstractArrayObjectInfo;
@@ -23,6 +22,7 @@
2322
import org.eclipse.wb.internal.core.utils.reflect.ReflectionUtils;
2423

2524
import org.eclipse.gef.EditPart;
25+
import org.eclipse.gef.requests.ChangeBoundsRequest;
2626

2727
/**
2828
* Implementation of {@link ILayoutRequestValidator} for validate items for <i>array object</i>.

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/policies/ILayoutRequestValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
*******************************************************************************/
1313
package org.eclipse.wb.gef.core.policies;
1414

15-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
1615
import org.eclipse.wb.gef.core.requests.CreateRequest;
1716
import org.eclipse.wb.gef.core.requests.PasteRequest;
1817

1918
import org.eclipse.gef.EditPart;
2019
import org.eclipse.gef.EditPolicy;
2120
import org.eclipse.gef.Request;
21+
import org.eclipse.gef.requests.ChangeBoundsRequest;
2222

2323
/**
2424
* Validator for known layout requests {@link Request#REQ_CREATE}, {@link Request#REQ_PASTE},

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/requests/ChangeBoundsRequest.java

Lines changed: 4 additions & 187 deletions
Original file line numberDiff line numberDiff line change
@@ -12,199 +12,16 @@
1212
*******************************************************************************/
1313
package org.eclipse.wb.gef.core.requests;
1414

15-
import org.eclipse.draw2d.geometry.Dimension;
16-
import org.eclipse.draw2d.geometry.Point;
17-
import org.eclipse.draw2d.geometry.Rectangle;
1815
import org.eclipse.gef.EditPart;
19-
import org.eclipse.gef.requests.DropRequest;
20-
import org.eclipse.gef.requests.GroupRequest;
2116

2217
/**
2318
* A {@link Request} to change the bounds of the {@link EditPart}(s).
2419
*
2520
* @author lobas_av
2621
* @coverage gef.core
22+
* @deprecated Use {@link org.eclipse.gef.requests.ChangeBoundsRequest
23+
* ChangeBoundsRequest} directly.
2724
*/
28-
public class ChangeBoundsRequest extends GroupRequest implements DropRequest {
29-
private static final int SNAP_TO = 16;
30-
private Point m_mouseLocation;
31-
private Point m_moveDelta = new Point();
32-
private Dimension m_resizeDelta = new Dimension();
33-
private int m_resizeDirection;
34-
private int m_flags = 0;
35-
36-
////////////////////////////////////////////////////////////////////////////
37-
//
38-
// Constructors
39-
//
40-
////////////////////////////////////////////////////////////////////////////
41-
/**
42-
* Constructs an empty {@link ChangeBoundsRequest}.
43-
*/
44-
public ChangeBoundsRequest() {
45-
}
46-
47-
/**
48-
* Constructs a {@link ChangeBoundsRequest} with the specified <i>type</i>.
49-
*/
50-
public ChangeBoundsRequest(Object type) {
51-
super(type);
52-
}
53-
54-
////////////////////////////////////////////////////////////////////////////
55-
//
56-
// Access
57-
//
58-
////////////////////////////////////////////////////////////////////////////
59-
/**
60-
* Returns the location of the mouse pointer.
61-
*/
62-
@Override
63-
public final Point getLocation() {
64-
return m_mouseLocation;
65-
}
66-
67-
/**
68-
* Sets the location of the mouse pointer.
69-
*/
70-
public void setLocation(Point location) {
71-
m_mouseLocation = location;
72-
}
73-
74-
/**
75-
* Returns a {@link Point} representing the distance the {@link EditPart} has moved.
76-
*/
77-
public Point getMoveDelta() {
78-
return m_moveDelta;
79-
}
80-
81-
/**
82-
* Sets the move delta.
83-
*/
84-
public void setMoveDelta(Point moveDelta) {
85-
m_moveDelta = moveDelta;
86-
}
87-
88-
/**
89-
* Returns a {@link Dimension} representing how much the {@link EditPart} has been resized.
90-
*/
91-
public Dimension getSizeDelta() {
92-
return m_resizeDelta;
93-
}
94-
95-
/**
96-
* Sets the size delta.
97-
*/
98-
public void setSizeDelta(Dimension sizeDelta) {
99-
m_resizeDelta = sizeDelta;
100-
}
101-
102-
/**
103-
* Returns the direction the figure is being resized. Possible values are
104-
* <ul>
105-
* <li>{@link org.eclipse.draw2d.PositionConstants#EAST}
106-
* <li>{@link org.eclipse.draw2d.PositionConstants#WEST}
107-
* <li>{@link org.eclipse.draw2d.PositionConstants#NORTH}
108-
* <li>{@link org.eclipse.draw2d.PositionConstants#SOUTH}
109-
* <li>{@link org.eclipse.draw2d.PositionConstants#NORTH_EAST}
110-
* <li>{@link org.eclipse.draw2d.PositionConstants#NORTH_WEST}
111-
* <li>{@link org.eclipse.draw2d.PositionConstants#SOUTH_EAST}
112-
* <li>{@link org.eclipse.draw2d.PositionConstants#SOUTH_WEST}
113-
* </ul>
114-
*/
115-
public int getResizeDirection() {
116-
return m_resizeDirection;
117-
}
118-
119-
/**
120-
* Sets the direction the figure is being resized.
121-
*
122-
* @see #getResizeDirection()
123-
*/
124-
public void setResizeDirection(int direction) {
125-
m_resizeDirection = direction;
126-
}
127-
128-
/**
129-
* Transforms a copy of the passed in rectangle to account for the move and/or resize deltas and
130-
* returns this copy.
131-
*/
132-
public Rectangle getTransformedRectangle(Rectangle rectangle) {
133-
Rectangle result = rectangle.getCopy();
134-
result.performTranslate(m_moveDelta);
135-
result.resize(m_resizeDelta);
136-
return result;
137-
}
138-
139-
////////////////////////////////////////////////////////////////////////////
140-
//
141-
// DND Feedback
142-
//
143-
////////////////////////////////////////////////////////////////////////////
144-
private int m_dndFeedback;
145-
146-
/**
147-
* @return additional DND feedback flags.
148-
*/
149-
public int getDNDFeedback() {
150-
return m_dndFeedback;
151-
}
152-
153-
/**
154-
* Sets additional DND feedback flags.
155-
*/
156-
public void setDNDFeedback(int dndFeedback) {
157-
m_dndFeedback = dndFeedback;
158-
}
159-
160-
////////////////////////////////////////////////////////////////////////////
161-
//
162-
// Snap to horizontal axis
163-
//
164-
////////////////////////////////////////////////////////////////////////////
165-
166-
/**
167-
* Used to set whether snap-to is being performed.
168-
*
169-
* @param value <code>true</code> if the request is for a creation with snap-to
170-
* enabled
171-
*/
172-
public void setSnapToEnabled(boolean value) {
173-
m_flags = value ? m_flags | SNAP_TO : m_flags & ~SNAP_TO;
174-
}
175-
176-
/**
177-
* Returns <code>true</code> if snap-to is enabled
178-
*
179-
* @return <code>true</code> if the request is for a creation with snap-to
180-
* enabled
181-
*/
182-
public boolean isSnapToEnabled() {
183-
return (m_flags & SNAP_TO) != 0;
184-
}
185-
186-
////////////////////////////////////////////////////////////////////////////
187-
//
188-
// Object
189-
//
190-
////////////////////////////////////////////////////////////////////////////
191-
@Override
192-
public String toString() {
193-
StringBuffer buffer = new StringBuffer("ChangeBoundsRequest(type=");
194-
buffer.append(getType());
195-
buffer.append(", editParts=");
196-
buffer.append(getEditParts());
197-
buffer.append(", m_flags=");
198-
buffer.append(m_flags);
199-
buffer.append(", location=");
200-
buffer.append(m_mouseLocation);
201-
buffer.append(", resizeDelta=");
202-
buffer.append(m_resizeDelta);
203-
buffer.append(", moveDelta=");
204-
buffer.append(m_moveDelta);
205-
buffer.append(", direction=");
206-
buffer.append(m_resizeDirection);
207-
buffer.append(")");
208-
return buffer.toString();
209-
}
25+
@Deprecated(forRemoval = true, since = "2026-06")
26+
public class ChangeBoundsRequest extends org.eclipse.gef.requests.ChangeBoundsRequest {
21027
}

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/tools/DragEditPartTracker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
*******************************************************************************/
1313
package org.eclipse.wb.gef.core.tools;
1414

15-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
1615
import org.eclipse.wb.gef.core.requests.DragPermissionRequest;
1716
import org.eclipse.wb.internal.gef.core.IObjectInfoEditPart;
1817
import org.eclipse.wb.internal.gef.core.SharedCursors;
@@ -27,6 +26,7 @@
2726
import org.eclipse.gef.RequestConstants;
2827
import org.eclipse.gef.commands.Command;
2928
import org.eclipse.gef.commands.CompoundCommand;
29+
import org.eclipse.gef.requests.ChangeBoundsRequest;
3030
import org.eclipse.gef.requests.GroupRequest;
3131
import org.eclipse.jface.viewers.StructuredSelection;
3232

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/tools/ParentTargetDragEditPartTracker.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
*******************************************************************************/
1313
package org.eclipse.wb.gef.core.tools;
1414

15-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
16-
1715
import org.eclipse.gef.EditPart;
16+
import org.eclipse.gef.requests.ChangeBoundsRequest;
1817

1918
import java.util.List;
2019

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/policies/LayoutEditPolicy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import org.eclipse.wb.gef.core.policies.DesignEditPolicy;
1616
import org.eclipse.wb.gef.core.policies.IEditPartDecorationListener;
1717
import org.eclipse.wb.gef.core.policies.ILayoutRequestValidator;
18-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
1918
import org.eclipse.wb.gef.core.requests.CreateRequest;
2019
import org.eclipse.wb.gef.core.requests.PasteRequest;
2120

@@ -24,6 +23,7 @@
2423
import org.eclipse.gef.Request;
2524
import org.eclipse.gef.RequestConstants;
2625
import org.eclipse.gef.commands.Command;
26+
import org.eclipse.gef.requests.ChangeBoundsRequest;
2727
import org.eclipse.gef.requests.GroupRequest;
2828

2929
import java.util.Iterator;

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/tools/ResizeTracker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
*******************************************************************************/
1313
package org.eclipse.wb.gef.graphical.tools;
1414

15-
import org.eclipse.wb.gef.core.requests.ChangeBoundsRequest;
1615
import org.eclipse.wb.gef.core.requests.KeyRequest;
1716
import org.eclipse.wb.gef.core.tools.Tool;
1817

@@ -25,6 +24,7 @@
2524
import org.eclipse.gef.Request;
2625
import org.eclipse.gef.commands.Command;
2726
import org.eclipse.gef.commands.CompoundCommand;
27+
import org.eclipse.gef.requests.ChangeBoundsRequest;
2828
import org.eclipse.swt.SWT;
2929
import org.eclipse.swt.events.KeyEvent;
3030
import org.eclipse.swt.graphics.Cursor;

0 commit comments

Comments
 (0)