Skip to content

Possibly misleading comment or bug #1595

@doxlik

Description

@doxlik

Version

both master and 5.x.x

Context

Hi dear Vertx team.

Inside io.vertx.pgclient.impl.codec.ExtendedQueryCommandCodec there is comment that either obsolete or at worst case there is missing code. Here it is

  @Override
  void encode(PgEncoder encoder) {
...
        if (cmd.paramsList().isEmpty()) {
          // We set suspended to false as we won't get a command complete command back from Postgres
          this.result = false;
          this.decoder.fireCommandResponse(CommandResponse.failure("Can not execute batch query with 0 sets of batch parameters."));
          return;
        }

can you please verify if this is outdated comment or really missed logic of suspending.

Steps to reproduce

No response

Do you have a reproducer?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions