You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 13, 2022. It is now read-only.
# Contributing to 'Eclipse Keyple' Java implementation
2
+
3
+
Thanks for your interest in this project.
4
+
5
+
## Project description
6
+
7
+
'Eclipse Keyple' Java implementation is a project containing all the content of the Java implementation of the [Eclipse Keyple](https://keyple.org/) API.
8
+
9
+
*https://github.com/eclipse/keyple-java
10
+
11
+
## Eclipse Contributor Agreement
12
+
13
+
Before your contribution can be accepted by the project team contributors must
14
+
electronically sign the Eclipse Contributor Agreement (ECA).
15
+
16
+
*http://www.eclipse.org/legal/ECA.php
17
+
18
+
Commits that are provided by non-committers must have a Signed-off-by field in
19
+
the footer indicating that the author is aware of the terms by which the
20
+
contribution has been provided to the project. The non-committer must
21
+
additionally have an Eclipse Foundation account and must have a signed Eclipse
22
+
Contributor Agreement (ECA) on file.
23
+
24
+
For more information, please see the Eclipse Committer Handbook:
You need a [GitHub](https://github.com/join) and an [Eclipse](https://accounts.eclipse.org/user/register) account for which you signed the [Eclipse Contributor Agreement](https://accounts.eclipse.org/user/login?destination=user/eca).
45
+
46
+
1. Fork the repository on GitHub
47
+
1. Check if there is a [Jira issue](https://keyple.atlassian.net/projects/KEYP) for what you want to work on or create one.
48
+
1. Announce in the comments section that you want to work on the issue. Also describe the solution you want to implement. To improve the chances for your contribution to be accepted, you'll want to wait for the feedback of the committers.
49
+
1. Create a new branch from *develop* for your changes. Name it after the Jira number, e.g. *KEYP-XXX_[descriptionofchanges]*.
50
+
1. Implement your changes.
51
+
1. Rebase on *develop*.
52
+
1. Run **./gradlew spotlessApply && android/gradlew spotlessApply** to format the code and add licence headers to the files.
53
+
1. Run **./gradlew check && android/gradlew check** (to check code formatting and run tests)
54
+
1. Commit using [Sign off](https://git-scm.com/docs/git-commit#git-commit--s) with the same email address you are using for your Eclipse account. Use descriptive and meaningful commit messages. In particular, start the first line of the commit message with the number of the issue that the commit addresses, e.g. *KEYP-XXX [descriptionofchanges]*.
55
+
1. Push your changes to your forked repository.
56
+
1. Create a [pull request (PR)](https://help.github.com/articles/using-pull-requests/) to *develop*.
57
+
1. After submitting, do not use your branch for any other development, otherwise further changes that you make will be visible in the PR.
58
+
59
+
## Contributing for Committers
60
+
You're a committer if you have write-access to the Keyple git-repositories.
61
+
62
+
1. Make sure there is a [Jira issue](https://keyple.atlassian.net/projects/KEYP) for what you want to work on or create one.
63
+
1. Assign the issue to yourself.
64
+
1. Create a local git branch from *develop*. Name it after the Jira number, e.g. *KEYP-XXX_[descriptionofchanges]*.
65
+
1. Implement your changes.
66
+
1. Rebase on *develop*.
67
+
1. Run **./gradlew spotlessApply && android/gradlew spotlessApply** to format the code and add licence headers to the files.
68
+
1. Run **./gradlew check && android/gradlew check** (to check code formatting and run tests)
69
+
1. Commit using [Sign off](https://git-scm.com/docs/git-commit#git-commit--s) with the same email address you are using for your Eclipse account. Use descriptive and meaningful commit messages. In particular, start the first line of the commit message with the number of the issue that the commit addresses, e.g. *KEYP-XXX Update Keyple Core Unit tests*.
70
+
1. Push the branch into the repository.
71
+
1. Create a pull request and ask somebody who is familiar with the code you modified to review it.
72
+
1. If the reviewer approves and all checks are OK, merge using squash commit.
0 commit comments