Conflicting filename if logs rolled very quickly

[cgay]

From @pedro-w:

"My grumble about the logging library (just so I don't forget) is that it uses a date-time derived filename for its rotating logs. I'm finding that if the LSP server crashes, VScode restarts it very quickly (i.e. within a second) and the new log filename is the same as the previous one. This causes the server to crash again, VScode restarts it very quickly and ... you get the picture. Not a big deal, for sure"

[pedro-w]

Some context: the LSP server sets up logging like this

define constant $lsp-log-target
  = make(<rolling-file-log-target>,
         pathname: merge-locators(as(<file-locator>,"lsp.log"),
                                  temp-directory()));

and if the server crashes we get 'follow on' crashes due to this issue, which look like this:

File exists: Can't rename /var/folders/jm/f8jztb557h7cygsnylsx6rd40000gn/T/lsp.log to /var/folders/jm/f8jztb557h7cygsnylsx6rd40000gn/T/lsp.log.20211007T211052
Backtrace:
  invoke-debugger:internal:dylan##1 + 0x29
  default-handler:dylan:dylan##1 + 0x12
  default-last-handler:common-dylan-internals:common-dylan##0 + 0x2b8
  error:dylan:dylan##0 + 0x26
  %rename-file:system-internals:system + 0x154
  roll-log-file:logging-impl:logging##0 + 0x10a
  initialize:dylan:dylan#logging#2 + 0x9c
  <rolling-file-log-target> constructor:logging-impl:logging##0 + 0xa5
  _Init_lsp_dylan__X_lsp_dylan_for_user + 0x7a
  main + 0x19
[Error - 9:10:52 PM] Connection to server got closed. Server will not be restarted.

I guess something similar might happen if multiple processes of a program using logging were started simultaneously.

[cgay]

Karma: I am now hitting this bug while using vscode-dylan.

[pedro-w]

1. Should the<rolling-file-log-target> append an ever-increasing integer to the file name?
2. Or should it sleep for 1 second if the files are opening too quickly (less good I think)
3. Should vscode-dylan be putting logs there at all, or should it be configurable?

Also: avoid writing code that crashes 😉

[cgay]

I have a patch with option 1 just about done, and for vscode I've made it put the log at the root of the workspace once the project has been opened.

[cgay]

I have a patch with option 1 just about done, and for vscode I've made it put the log at the root of the workspace once the project has been opened.

Not "for vscode" but rather "in lsp-dylan".