Skip to content

Commit 2ca20a7

Browse files
committed
Merge branch 'master' of https://github.com/durs/node-activex
2 parents 87dc4c5 + 886784d commit 2ca20a7

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
strategy:
88
fail-fast: false
99
matrix:
10-
node-version: ['18.x', '20.x', '22.x', '23.x']
10+
node-version: ['18.x', '20.x', '22.x', '24.x', '25.x']
1111
os: [windows-latest]
1212
runs-on: ${{ matrix.os }}
1313
steps:

src/disp.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1123,12 +1123,18 @@ void VariantObject::NodeGet(Local<Name> name, const PropertyCallbackInfoGetter&
11231123
if ((self->value.vt & VT_ARRAY) != 0) {
11241124
args.GetReturnValue().Set((uint32_t)self->value.ArrayLength());
11251125
}
1126-
}
1126+
else {
1127+
args.GetReturnValue().SetUndefined();
1128+
}
1129+
}
11271130
else {
11281131
Local<Function> func;
11291132
if (clazz_methods.get(isolate, id, &func)) {
11301133
args.GetReturnValue().Set(func);
11311134
}
1135+
else {
1136+
args.GetReturnValue().SetUndefined();
1137+
}
11321138
}
11331139
}
11341140

0 commit comments

Comments
 (0)