Skip to content

Commit 5b74b1b

Browse files
committed
Mark presign tests as #[ignore] (require minio)
test_presign_get, test_presign_put, test_presign_post, and test_presign_delete all call test_minio_bucket() which reads MINIO_ACCESS_KEY_ID from the environment. Without a running minio instance these tests panic, breaking `make ci` / `cargo test`. All other integration tests that need external services are already marked #[ignore]. These four were just missing the attribute.
1 parent 3eb5fdf commit 5b74b1b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

s3/src/bucket.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3784,6 +3784,7 @@ mod test {
37843784
put_head_delete_object_with_headers(*test_r2_bucket()).await;
37853785
}
37863786

3787+
#[ignore]
37873788
#[maybe_async::test(
37883789
feature = "sync",
37893790
async(all(not(feature = "sync"), feature = "with-tokio"), tokio::test),
@@ -3811,6 +3812,7 @@ mod test {
38113812
assert!(url.contains("/test/test.file"))
38123813
}
38133814

3815+
#[ignore]
38143816
#[maybe_async::test(
38153817
feature = "sync",
38163818
async(all(not(feature = "sync"), feature = "with-tokio"), tokio::test),
@@ -3839,6 +3841,7 @@ mod test {
38393841
assert_eq!(data.dynamic_fields.len(), 1);
38403842
}
38413843

3844+
#[ignore]
38423845
#[maybe_async::test(
38433846
feature = "sync",
38443847
async(all(not(feature = "sync"), feature = "with-tokio"), tokio::test),
@@ -3855,6 +3858,7 @@ mod test {
38553858
assert!(url.contains("/test/test.file?"))
38563859
}
38573860

3861+
#[ignore]
38583862
#[maybe_async::test(
38593863
feature = "sync",
38603864
async(all(not(feature = "sync"), feature = "with-tokio"), tokio::test),

0 commit comments

Comments
 (0)