Http Proxy support?

[bemar76]

Hello,

how can I get support for http proxy?
I did not find another way than having code changes in the sdk modul to get OkHttp to use proxy.

Thank you

Benjamin

[AaronAtDuo]

@bemar76 We definitely have plans to add proxy support to this, as well as the other languages' Duo Universal clients. Unfortunately, that's not quite at the top of our priority list at the moment, so I can't give you a good estimate on when that might happen.

[bemar76]

@AaronAtDuo
I've implemented it already because we have a proxy infrastructure in our company. If your are interested for the code, let me know.

[AaronAtDuo]

@bemar76 We'd definitely be interested! If you've got a fork with the change, or want to put together a PR, etc. we'd definitely take a look.

[bemar76]

Hallo Aaron,

you can find my approach here

https://github.com/bemar76/duo_universal_java/

Sorry for choosing wrong character set.

[AaronAtDuo]

I'll take a look! We'll see when we can get proxy support prioritized. It'll probably be after we add a couple more languages though.

Thanks for the note.

[LMCO-Richard]

@AaronAtDuo @bemar76 I don't see a pull request was made. @bemar76 code with proxy added works for me. Can we make a pull request and get this added?

[LMCO-Richard]

@AaronAtDuo Also, could you please upgrade the com.auth0.java-jwt dependency to the latest version as one of its transitive dependencies Apache Commons Codec introduces breakage with new versions of Apache Commons Codec. In the latest version of com.auth0.java-jwt, the transitive dependency Apache Commons Codec has been removed.

[AaronAtDuo]

@LMCO-Richard I'll see what I can do. It looks like in the latest version (4.0.0) they changed the signature of something we use, so it's not a simple pom-only update...

[AaronAtDuo]

Ok #19 is in for the dependency update, fingers crossed that it passes CI.

[AaronAtDuo]

@LMCO-Richard Commit 0febdbf updates the JWT library dependency.

HTTP proxy support might take a bit longer - do you want to wait for that, or should I do a release with just the dependency change?

[LMCO-Richard]

@AaronAtDuo Thank you for addressing the dependency issue. Yes, I'd like to wait for the HTTP proxy support. I believe it should be pretty straightforward as @bemar76 already has all the required code changes in his repo. Thanks again!

[bemar76]

You're welcome. Proud do have some of my code inside this amazing project.

[eosmith]

@AaronAtDuo I've incorporated the http proxy server support from the excellent fork by @bemar76 into my own fork from the the most recent version of this project and submitted a pull request. Our team at Carnegie Mellon would greatly appreciate it if Duo would approve this request so we don't have to maintain a separate project from yours that offers proxy server support. It appears from the comments that others would benefit as well. Thank you for your consideration.

[AaronAtDuo]

@eosmith I definitely plan to look this over and try to get it merged next week.