build(deps): bump actions/upload-artifact from 4 to 5 (#2037)

* build(deps): bump actions/upload-artifact from 4 to 5

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Refactor: Rename artifact names in CI workflows

Co-authored-by: jkingston <jkingston@duckduckgo.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: jkingston <jkingston@duckduckgo.com>

Author: 3 people

.github/workflows/snapshots.yml

@@ -55,10 +55,10 @@ jobs:
 
             - run: npm run test-int-snapshots
 
-            - uses: actions/upload-artifact@v4
+            - uses: actions/upload-artifact@v5
               if: always()
               with:
-                  name: playwright-report-pages
+                  name: snapshots-playwright-report
                   path: |
                       special-pages/playwright-report/**
                       special-pages/test-results/**

.github/workflows/tests.yml

@@ -66,16 +66,16 @@ jobs:
             - name: Install Playwright Browsers
               run: npx playwright install --with-deps
             - run: npm run test-int-x
-            - uses: actions/upload-artifact@v4
+            - uses: actions/upload-artifact@v5
               if: always()
               with:
-                  name: playwright-report-pages
+                  name: tests-playwright-report-pages
                   path: special-pages/playwright-report
                   retention-days: 5
-            - uses: actions/upload-artifact@v4
+            - uses: actions/upload-artifact@v5
               if: always()
               with:
-                  name: playwright-report-injected
+                  name: tests-playwright-report-injected
                   path: injected/playwright-report
                   retention-days: 5
             - name: Build docs