Default ?omnibar to true

Author: noisysocks

special-pages/pages/new-tab/app/mock-transport.js

@@ -586,7 +586,7 @@ export function initialSetup(url) {
     widgetsFromStorage.push({ id: 'protections' });
     widgetConfigFromStorage.push({ id: 'protections', visibility: 'visible' });
 
-    if (url.searchParams.has('omnibar')) {
+    if (url.searchParams.get('omnibar') !== 'false') {
         const favoritesWidgetIndex = widgetsFromStorage.findIndex((widget) => widget.id === 'favorites') ?? 0;
         widgetsFromStorage.splice(favoritesWidgetIndex, 0, { id: 'omnibar' });
         const favoritesWidgetConfigIndex = widgetConfigFromStorage.findIndex((widget) => widget.id === 'favorites') ?? 0;

special-pages/pages/new-tab/integration-tests/new-tab.spec.js

@@ -27,6 +27,7 @@ test.describe('newtab widgets', () => {
                     context: 'specialPages',
                     featureName: 'newTabPage',
                     params: [
+                        { id: 'omnibar', visibility: 'visible' },
                         { id: 'favorites', visibility: 'visible' },
                         { id: 'protections', visibility: 'hidden' },
                     ],
@@ -60,6 +61,7 @@ test.describe('newtab widgets', () => {
                     context: 'specialPages',
                     featureName: 'newTabPage',
                     params: [
+                        { id: 'omnibar', visibility: 'visible' },
                         { id: 'favorites', visibility: 'visible' },
                         { id: 'protections', visibility: 'visible' },
                     ],
@@ -85,6 +87,10 @@ test.describe('newtab widgets', () => {
             method: 'contextMenu',
             params: {
                 visibilityMenuItems: [
+                    {
+                        id: 'omnibar',
+                        title: 'Search',
+                    },
                     {
                         id: 'favorites',
                         title: 'Favorites',