The plugin sends notifications as successful.

[sviatoslav6]

The plugin sends notifications as successful, even when some steps in the pipeline have failed and resulted in an error.

My pipeline

kind: pipeline
type: kubernetes
name: test

trigger:
  branch:
    - master

clone:
  disable: true

steps:
  - name: test
    image: bitnami/git
    environment:
      SLACK_WEBHOOK:
        from_secret: SLACK_WEBHOOK
    commands:
      - kubectl get pod
    when:
      event: [push]

  - name: slack-notify
    image: plugins/slack
    environment:
      SLACK_WEBHOOK:
        from_secret: SLACK_WEBHOOK
    settings:
      webhook: $${SLACK_WEBHOOK}
      channel: my-channel
      template: >

        {{#success build.status}} ✔ {{ else }} :x: {{/success}} {{ uppercasefirst build.status }}: Build #{{ build.number }} * (type: `{{ build.event }}`)

        Repository:  <https://github.com/{{ repo.name }}>

        Commit: <https://github.com/{{ repo.owner }}/{{ repo.name }}/commit/{{ build.commit }}|{{ truncate build.commit 8 }}>

        Branch: <https://github.com/{{ repo.owner }}/{{ repo.name }}/commits/{{ build.branch }}|{{ build.branch }}>

        Author: {{ build.author }}

        Build: <{{ build.link }}| Drone Build {{ build.number }} ↗>
    when:
      event: [push]
      status: [success, failure]
      branch: [master]
    depends_on:
      - test

step test ends with an error, because no such command

in the slack message that the build was successful

[sviatoslav6]

When I use tag 1.4.1, everything works as before

[thelazyoxymoron]

Facing the same issue

[casdr]

Something weird I noticed is that when I add a step that runs the export command, it shows the following:

export DRONE_BUILD_STATUS='success'

This explains why the plugin shows the build as being successful, but it doesn't explain why it did detect a failed build in the previous version. I couldn't really find a related change in the diffs between tag 1.4.1 (and earlier) and master.

One workaround for this is moving the plugin to a separate stage, which depends on the 'main' stage and has the following trigger:

---
[build stage]

---
kind: pipeline
type: kubernetes
name: notify slack
depends_on:
  - build stage

triggers:
  status:
    - success
    - failure

steps:
[ slack step ]

When testing with the export command, you'll also see te following in this case:

export DRONE_BUILD_STATUS='failure'