fix: correct boolean flag definitions for https and chat-mode#3
Open
larryxiao625 wants to merge 2 commits intodreampulse:mainfrom
Open
fix: correct boolean flag definitions for https and chat-mode#3larryxiao625 wants to merge 2 commits intodreampulse:mainfrom
larryxiao625 wants to merge 2 commits intodreampulse:mainfrom
Conversation
The previous syntax with default value `true` caused these options to always remain true and could not be disabled by users. Changed to use --no-https and --no-chat-mode flags to properly enable these features by default while allowing users to disable them with the negative flags.
Update documentation to use --no-https and --no-chat-mode flags instead of the previous incorrect syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous syntax with default value
truecaused these options to always remain true and could not be disabled by users. Changed to use --no-https and --no-chat-mode flags to properly enable these features by default while allowing users to disable them with the negative flags.