Skip to content

Fix: Persist settings on load and improve utils robustness #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shalini-saloni wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Persist settings on load and improve utils robustness #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca0247
fix: persist settings on load and improve utils robustness
shalini-saloni Nov 30, 2025
34405ba
Merge branch 'main' into fix/settings-and-utils
shalini-saloni Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/context/SettingsContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,10 @@ const defaultSettings = {
export const SettingsContext = createContext(defaultSettings);

export default function SettingsContextProvider({ children }) {
const [settings, setSettings] = useState(defaultSettings);

useEffect(() => {
const settings = localStorage.getItem("settings");
if (settings) {
setSettings(JSON.parse(settings));
}
}, []);
const [settings, setSettings] = useState(() => {
const savedSettings = localStorage.getItem("settings");
return savedSettings ? JSON.parse(savedSettings) : defaultSettings;
});

useEffect(() => {
document.body.setAttribute("theme-mode", settings.mode);
Expand Down
4 changes: 4 additions & 0 deletions src/utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import {
} from "../data/constants";

export function dataURItoBlob(dataUrl) {
if (!dataUrl || !dataUrl.includes(",")) {
console.error("Invalid data URI");
return new Blob([]);
}
const byteString = atob(dataUrl.split(",")[1]);
const mimeString = dataUrl.split(",")[0].split(":")[1].split(";")[0];
const arrayBuffer = new ArrayBuffer(byteString.length);
Expand Down