From 6ab1a4b53c2f0e180d3bd6db32a5285483c13cd9 Mon Sep 17 00:00:00 2001 From: rcj1 Date: Fri, 6 Feb 2026 06:20:56 -0800 Subject: [PATCH 1/3] testing --- src/coreclr/vm/debugdebugger.cpp | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/coreclr/vm/debugdebugger.cpp b/src/coreclr/vm/debugdebugger.cpp index cd33e4f168871f..8e152de1ec3d2f 100644 --- a/src/coreclr/vm/debugdebugger.cpp +++ b/src/coreclr/vm/debugdebugger.cpp @@ -298,14 +298,16 @@ extern "C" void QCALLTYPE AsyncHelpers_AddContinuationToExInternal( _ASSERTE(pException != NULL); // populate exception with information from the continuation object EECodeInfo codeInfo((PCODE)diagnosticIP); - _ASSERTE(codeInfo.IsValid()); - MethodDesc* methodDesc = codeInfo.GetMethodDesc(); - StackTraceInfo::AppendElement( - pException, - (UINT_PTR)diagnosticIP, - 0, - methodDesc, - NULL); + if (codeInfo.IsValid()) + { + MethodDesc* methodDesc = codeInfo.GetMethodDesc(); + StackTraceInfo::AppendElement( + pException, + (UINT_PTR)diagnosticIP, + 0, + methodDesc, + NULL); + } END_QCALL; } From baebee55f92a1f2d653b851bc2ad53bf72819807 Mon Sep 17 00:00:00 2001 From: Rachel Date: Fri, 6 Feb 2026 11:49:12 -0800 Subject: [PATCH 2/3] Update debugdebugger.cpp --- src/coreclr/vm/debugdebugger.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/coreclr/vm/debugdebugger.cpp b/src/coreclr/vm/debugdebugger.cpp index 8e152de1ec3d2f..27f4947f2bb46f 100644 --- a/src/coreclr/vm/debugdebugger.cpp +++ b/src/coreclr/vm/debugdebugger.cpp @@ -298,6 +298,8 @@ extern "C" void QCALLTYPE AsyncHelpers_AddContinuationToExInternal( _ASSERTE(pException != NULL); // populate exception with information from the continuation object EECodeInfo codeInfo((PCODE)diagnosticIP); + // Interpreter diagnostic IP is not recognized by codeInfo, so this does not work with interpreted code. + // Tracking issue: https://github.com/dotnet/runtime/issues/124044 if (codeInfo.IsValid()) { MethodDesc* methodDesc = codeInfo.GetMethodDesc(); From b2783117a23bb26113773999201c4f9ca3a5a734 Mon Sep 17 00:00:00 2001 From: Rachel Date: Fri, 6 Feb 2026 11:59:25 -0800 Subject: [PATCH 3/3] Add temporary comment for testing in debugdebugger.cpp Add a comment regarding the temporary measure for testing. --- src/coreclr/vm/debugdebugger.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/coreclr/vm/debugdebugger.cpp b/src/coreclr/vm/debugdebugger.cpp index 27f4947f2bb46f..aba16c6007de25 100644 --- a/src/coreclr/vm/debugdebugger.cpp +++ b/src/coreclr/vm/debugdebugger.cpp @@ -299,6 +299,7 @@ extern "C" void QCALLTYPE AsyncHelpers_AddContinuationToExInternal( // populate exception with information from the continuation object EECodeInfo codeInfo((PCODE)diagnosticIP); // Interpreter diagnostic IP is not recognized by codeInfo, so this does not work with interpreted code. + // This is a temporary measure to enable testing and once the issue is fixed this condition should be replaced by an assert. // Tracking issue: https://github.com/dotnet/runtime/issues/124044 if (codeInfo.IsValid()) {