Skip to content

Commit 68b6089

Browse files
Scope installer tests to installer changes, keep osx_arm64 for coreclr
Change Installer_Build_And_Test job conditions from non_mono_and_wasm.containsChange to installer.containsChange for most platforms. Previously, installer helix tests (5 platforms) ran on any non-mono change including pure coreclr or libraries changes. Split osx_arm64 into its own block with a broader condition that also includes coreclr.containsChange, per Elinor Fung's guidance that Mac ARM64 is most likely to catch single-file issues from coreclr changes. - windows_x86, osx_x64: installer OR rolling only - windows_x64, linux_x64: installer OR rolling only - osx_arm64: coreclr OR installer OR rolling Saves 4 helix jobs on coreclr-only PRs (was 5, now 1 remains). Saves 5 helix jobs on libraries-only PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 91557f5 commit 68b6089

1 file changed

Lines changed: 34 additions & 3 deletions

File tree

eng/pipelines/runtime.yml

Lines changed: 34 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1495,7 +1495,7 @@ extends:
14951495
creator: dotnet-bot
14961496
condition:
14971497
or(
1498-
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_non_mono_and_wasm.containsChange'], true),
1498+
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
14991499
eq(variables['isRollingBuild'], true))
15001500

15011501
- template: /eng/pipelines/common/platform-matrix.yml
@@ -1504,7 +1504,6 @@ extends:
15041504
buildConfig: release
15051505
platforms:
15061506
- windows_x64
1507-
- osx_arm64
15081507
- linux_x64
15091508
helixQueuesTemplate: /eng/pipelines/installer/helix-queues-setup.yml
15101509
jobParameters:
@@ -1527,7 +1526,39 @@ extends:
15271526
creator: dotnet-bot
15281527
condition:
15291528
or(
1530-
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_non_mono_and_wasm.containsChange'], true),
1529+
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
1530+
eq(variables['isRollingBuild'], true))
1531+
1532+
# osx_arm64 installer tests also run on coreclr changes to catch single-file issues
1533+
- template: /eng/pipelines/common/platform-matrix.yml
1534+
parameters:
1535+
jobTemplate: /eng/pipelines/common/global-build-job.yml
1536+
buildConfig: release
1537+
platforms:
1538+
- osx_arm64
1539+
helixQueuesTemplate: /eng/pipelines/installer/helix-queues-setup.yml
1540+
jobParameters:
1541+
nameSuffix: Installer_Build_And_Test
1542+
buildArgs: -s host+packs -c $(_BuildConfig) -lc ${{ variables.debugOnPrReleaseOnRolling }} -rc Release
1543+
dependsOnGlobalBuilds:
1544+
- nameSuffix: CoreCLR_Libraries
1545+
buildConfig: ${{ variables.debugOnPrReleaseOnRolling }}
1546+
preBuildSteps:
1547+
- template: /eng/pipelines/common/download-artifact-step.yml
1548+
parameters:
1549+
artifactName: CoreCLR_Libraries_BuildArtifacts_$(osGroup)$(osSubgroup)_$(archType)_$(debugOnPrReleaseOnRolling)
1550+
artifactFileName: CoreCLR_Libraries_BuildArtifacts_$(osGroup)$(osSubgroup)_$(archType)_$(debugOnPrReleaseOnRolling)$(archiveExtension)
1551+
unpackFolder: $(Build.SourcesDirectory)/artifacts/bin
1552+
displayName: 'unified artifacts'
1553+
timeoutInMinutes: 150
1554+
postBuildSteps:
1555+
- template: /eng/pipelines/installer/helix.yml
1556+
parameters:
1557+
creator: dotnet-bot
1558+
condition:
1559+
or(
1560+
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true),
1561+
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
15311562
eq(variables['isRollingBuild'], true))
15321563

15331564
#

0 commit comments

Comments
 (0)