diff --git a/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt b/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt index c7a9131..308dc2c 100755 --- a/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt +++ b/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt @@ -28,8 +28,6 @@ class UrlEncoderUtils private constructor() { if (isValidHexChar(c1) && isValidHexChar(c2)) { encode = true break - } else { - break } } } diff --git a/dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt b/dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt new file mode 100644 index 0000000..c01a838 --- /dev/null +++ b/dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt @@ -0,0 +1,19 @@ +package dora.http.log + +import org.junit.Assert.assertFalse +import org.junit.Assert.assertTrue +import org.junit.Test + +class UrlEncoderUtilsTest { + + @Test + fun hasUrlEncoded_detectsValidSequences() { + assertTrue(UrlEncoderUtils.hasUrlEncoded("abc%20def")) + } + + @Test + fun hasUrlEncoded_ignoresInvalidSequences() { + assertTrue(UrlEncoderUtils.hasUrlEncoded("abc%2G%20def")) + assertFalse(UrlEncoderUtils.hasUrlEncoded("abc%2Gdef")) + } +}