Skip to content

Conversation

@Den-Rimus
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-implements the pdf-generation example by splitting the original MainActivity into separate activities for PDF generation with and without OCR, along with corresponding layout changes.

Key Changes:

  • Extracted PDF generation logic into two new activities: PdfActivity (without OCR) and PdfWithOcrActivity (with OCR)
  • Simplified MainActivity to serve as a launcher screen with navigation buttons
  • Migrated from sdk-package-1 to sdk-package-2 to include OCR functionality

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
classic-components-example/pdf-generation/src/main/res/layout/activity_pdf.xml New layout file for PDF generation activities with image loader, grayscale checkbox, and progress indicator
classic-components-example/pdf-generation/src/main/res/layout/activity_main.xml Refactored to display two navigation buttons (PDF and PDF with OCR) instead of image processing controls
classic-components-example/pdf-generation/src/main/java/io/scanbot/example/PdfWithOcrActivity.kt New activity implementing PDF generation with OCR functionality
classic-components-example/pdf-generation/src/main/java/io/scanbot/example/PdfActivity.kt New activity implementing PDF generation without OCR
classic-components-example/pdf-generation/src/main/java/io/scanbot/example/MainActivity.kt Simplified to act as a launcher with navigation to PDF activities
classic-components-example/pdf-generation/src/main/AndroidManifest.xml Added activity declarations for the two new PDF activities
classic-components-example/pdf-generation/build.gradle Updated SDK package dependency and reorganized build configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@4BooM04
Copy link
Contributor

4BooM04 commented Dec 3, 2025

@Den-Rimus apply copilot comments please

@Den-Rimus Den-Rimus force-pushed the dd/EPIC-6675-pdf-generation-with-OCR branch from 157ba91 to 95532a7 Compare December 4, 2025 15:56
@Kubiria Kubiria merged commit b642af1 into android_ds_8.0.0 Dec 8, 2025
@Kubiria Kubiria deleted the dd/EPIC-6675-pdf-generation-with-OCR branch December 8, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants