-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathfind_replace_test.go
More file actions
962 lines (830 loc) · 31 KB
/
Copy pathfind_replace_test.go
File metadata and controls
962 lines (830 loc) · 31 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
package main
import (
"bytes"
"errors"
"io/fs"
"os"
"os/exec"
"path/filepath"
"runtime"
"strings"
"testing"
)
/*
* Testing utilities
*/
// newTestFile creates a file in the given directory path, with the given name
// and content. If a directory path is not provided, a temp directory is used.
// If a baseName is not provided, a random file name is generated. Returns the
// directory where the file was created, the file's directory entry, and the
// actual name of the file.
func newTestFile(tb testing.TB, path string, baseName string, content string) *File {
tb.Helper()
f, err := os.CreateTemp(path, baseName)
if err != nil {
tb.Fatalf("CreateTemp(%q, %q): %v", path, baseName, err)
}
if _, err := f.Write([]byte(content)); err != nil {
defer os.Remove(f.Name())
tb.Fatalf("write to %v: %v", f.Name(), err)
}
if err := f.Close(); err != nil {
defer os.Remove(f.Name())
tb.Fatalf("close %v: %v", f.Name(), err)
}
return newFileOrFatal(tb, f.Name())
}
// newTestDir creates a directory in the given directory path, with the given
// base name. If a directory path is not provided, a temp directory is used. If
// a baseName is not provided, a random file name is generated. Returns the
// directory where the file was created, the file's directory entry, and the
// actual name of the file.
func newTestDir(tb testing.TB, path string, baseName string) *File {
tb.Helper()
dirPath, err := os.MkdirTemp(path, baseName)
if err != nil {
tb.Fatalf("MkdirTemp(%q, %q): %v", path, baseName, err)
}
return newFileOrFatal(tb, dirPath)
}
// newFileOrFatal wraps NewFile for tests that should never see the
// (vanishingly rare) filepath.Abs error.
func newFileOrFatal(tb testing.TB, path string) *File {
tb.Helper()
f, err := NewFile(path)
if err != nil {
tb.Fatalf("NewFile(%q): %v", path, err)
}
return f
}
// readOrFatal returns the contents of f or fails the test.
func readOrFatal(tb testing.TB, f *File) string {
tb.Helper()
s, err := f.Read()
if err != nil {
tb.Fatalf("Read(%q): %v", f.Path, err)
}
return s
}
// requireSymlinks skips the calling test if the test process cannot create
// symbolic links. On Windows this typically requires
// SeCreateSymbolicLinkPrivilege; on sandboxed Linux filesystems and certain
// container configurations the syscall can also fail with EPERM/ENOSYS.
// Probing for the actual capability avoids skipping on a host where symlinks
// happen to work, and avoids running on a host where they happen not to.
func requireSymlinks(t *testing.T) {
t.Helper()
probe := t.TempDir()
target := filepath.Join(probe, "target")
if err := os.WriteFile(target, nil, 0600); err != nil {
t.Fatalf("requireSymlinks setup: WriteFile(%q): %v", target, err)
}
link := filepath.Join(probe, "link")
if err := os.Symlink(target, link); err != nil {
t.Skipf("symlinks not supported in this environment: %v", err)
}
}
func expectedPathAfterRename(f *File, fr *findReplace) string {
return filepath.Join(f.Dir(), strings.ReplaceAll(f.Base(), fr.find, fr.replace))
}
/*
* Assertions
*/
// assertFileExists ensures that the given File exists
func assertFileExists(t *testing.T, f *File) {
t.Helper()
if _, err := os.Stat(f.Path); errors.Is(err, os.ErrNotExist) {
t.Errorf("test file %v does not exist", f.Path)
}
}
// assertFileNonexistent ensures that the File does not exist
func assertFileNonexistent(t *testing.T, f *File) {
t.Helper()
if _, err := os.Stat(f.Path); !errors.Is(err, os.ErrNotExist) {
if err == nil {
t.Errorf("test file %v exists", f.Path)
} else {
t.Errorf("test file %v exists (got %v)", f.Path, err)
}
}
}
func assertPathExistsAfterRename(t *testing.T, f *File, expectedPath string) *File {
t.Helper()
assertFileNonexistent(t, f)
newFile := newFileOrFatal(t, expectedPath)
assertFileExists(t, newFile)
return newFile
}
/*
* Tests
*/
// TestWalkDir is the most important test of the entire suite, because it
// exercises all the basic functionality of the app. It builds a directory tree
// of temporary files and directories, walks the entire tree, and ensures that
// all files and directories are appropriately renamed at at the end, and all
// files contain the correct contents.
func TestWalkDir(t *testing.T) {
find := "wh"
replace := "f"
d := newTestDir(t, "", "*")
defer os.Remove(d.Path)
// d1: who/
d1 := newTestDir(t, d.Path, "who")
defer os.Remove(d1.Path)
// d1d1: who/what/
d1d1 := newTestDir(t, d1.Path, "what")
defer os.Remove(d1d1.Path)
// d1d1f1: who/what/when (contains "where")
d1d1f1Contents := "where"
d1d1f1 := newTestFile(t, d1d1.Path, "when", d1d1f1Contents)
defer os.Remove(d1d1f1.Path)
// d2: what/
d2 := newTestDir(t, d.Path, "what")
defer os.Remove(d2.Path)
// d2d1: what/when/
d2d1 := newTestDir(t, d2.Path, "when")
defer os.Remove(d2d1.Path)
// d2d1d1: what/when/where (directories with no files)
d2d1d1 := newTestDir(t, d2d1.Path, "where")
defer os.Remove(d2d1d1.Path)
// d3: when/
d3 := newTestDir(t, d.Path, "when")
defer os.Remove(d3.Path)
// d3f1: when/where (contains "why")
d3f1Contents := "why"
d3f1 := newTestFile(t, d3.Path, "where", d3f1Contents)
defer os.Remove(d3f1.Path)
// d4: where/ (empty directory in base dir)
d4 := newTestDir(t, d.Path, "where")
defer os.Remove(d4.Path)
// f1: why (file in base dir contains "wh")
f1Contents := "wh\nwh\nwh\n"
f1 := newTestFile(t, d.Path, "why", f1Contents)
defer os.Remove(f1.Path)
fr := findReplace{find: find, replace: replace}
fr.WalkDir(d)
if err := fr.errs.err(); err != nil {
t.Fatalf("WalkDir reported errors: %v", err)
}
// d1: who/ > fo/
d1ExpectedPath := expectedPathAfterRename(d1, &fr)
assertPathExistsAfterRename(t, d1, d1ExpectedPath)
// d1d1: who/what/ > fo/foat/
d1d1ExpectedPath := filepath.Join(d1ExpectedPath, strings.ReplaceAll(d1d1.Base(), fr.find, fr.replace))
assertPathExistsAfterRename(t, d1d1, d1d1ExpectedPath)
// d1d1f1: who/what/when > fo/fat/fen (contains "fere")
d1d1f1ExpectedPath := filepath.Join(d1d1ExpectedPath, strings.ReplaceAll(d1d1f1.Base(), fr.find, fr.replace))
assertPathExistsAfterRename(t, d1d1f1, d1d1f1ExpectedPath)
assertNewContentsOfFile(t, d1d1f1ExpectedPath, d1d1f1Contents, find, replace, "fere")
// d2: what/ > fat/
d2ExpectedPath := expectedPathAfterRename(d2, &fr)
assertPathExistsAfterRename(t, d2, d2ExpectedPath)
// d2d1: what/when/
d2d1ExpectedPath := filepath.Join(d2ExpectedPath, strings.ReplaceAll(d2d1.Base(), fr.find, fr.replace))
assertPathExistsAfterRename(t, d2d1, d2d1ExpectedPath)
// d2d1d1: what/when/where (directories with no files)
d2d1d1ExpectedPath := filepath.Join(d2d1ExpectedPath, strings.ReplaceAll(d2d1d1.Base(), fr.find, fr.replace))
assertPathExistsAfterRename(t, d2d1d1, d2d1d1ExpectedPath)
// d3: when/
d3ExpectedPath := expectedPathAfterRename(d3, &fr)
assertPathExistsAfterRename(t, d3, d3ExpectedPath)
// d3f1: when/where (contains "why")
d3f1ExpectedPath := filepath.Join(d3ExpectedPath, strings.ReplaceAll(d3f1.Base(), fr.find, fr.replace))
assertPathExistsAfterRename(t, d3f1, d3f1ExpectedPath)
assertNewContentsOfFile(t, d3f1ExpectedPath, d3f1Contents, find, replace, "fy")
// d4: where/ (empty directory in base dir)
d4ExpectedPath := expectedPathAfterRename(d4, &fr)
assertPathExistsAfterRename(t, d4, d4ExpectedPath)
// f1: why (file in base dir contains "wh\nwh\nwh\n")
f1ExpectedPath := expectedPathAfterRename(f1, &fr)
assertPathExistsAfterRename(t, f1, f1ExpectedPath)
assertNewContentsOfFile(t, f1ExpectedPath, f1Contents, find, replace, "f\nf\nf\n")
}
func TestHandleFileWithDir(t *testing.T) {
initial := "alpha"
find := "ph"
replace := "f"
f := newTestDir(t, "", initial)
defer os.Remove(f.Path)
expectedPath := filepath.Join(f.Dir(), strings.ReplaceAll(f.Base(), find, replace))
defer os.Remove(expectedPath)
fr := findReplace{find: find, replace: replace}
assertFileExists(t, f)
if err := fr.HandleFile(f); err != nil {
t.Fatalf("HandleFile(%q): %v", f.Path, err)
}
assertPathExistsAfterRename(t, f, expectedPath)
}
func TestHandleFileWithIgnoredDir(t *testing.T) {
initial := ".git"
find := "git"
replace := "got"
dirPath := filepath.Join(t.TempDir(), initial)
if err := os.Mkdir(dirPath, 0700); err != nil {
t.Fatalf("Mkdir(%q): %v", dirPath, err)
}
f := newFileOrFatal(t, dirPath)
// Just in case it's unexpectedly renamed, let's make sure we cleanup the
// anticipated name.
unexpectedName := strings.ReplaceAll(f.Base(), find, replace)
unexpectedPath := filepath.Join(f.Dir(), unexpectedName)
defer os.Remove(unexpectedPath)
fr := findReplace{find: find, replace: replace}
assertFileExists(t, f)
if err := fr.HandleFile(f); err != nil {
t.Fatalf("HandleFile(%q): %v", f.Path, err)
}
assertFileExists(t, f)
}
func TestHandleFileWithFile(t *testing.T) {
initial := "alpha"
find := "ph"
replace := "f"
want := "alfa"
f := newTestFile(t, "", initial, initial)
defer os.Remove(f.Path)
expectedName := strings.ReplaceAll(f.Base(), find, replace)
expectedPath := filepath.Join(f.Dir(), expectedName)
defer os.Remove(expectedPath)
fr := findReplace{find: find, replace: replace}
assertFileExists(t, f)
if err := fr.HandleFile(f); err != nil {
t.Fatalf("HandleFile(%q): %v", f.Path, err)
}
assertPathExistsAfterRename(t, f, expectedPath)
got := readOrFatal(t, newFileOrFatal(t, expectedPath))
if got != want {
t.Errorf("replace %v with %v in %v, but got %v; want %v", find, replace, initial, got, want)
}
}
func TestRenameFile(t *testing.T) {
initial := "alpha"
find := "ph"
replace := "f"
f := newTestFile(t, "", initial, "")
defer os.Remove(f.Path)
expectedName := strings.ReplaceAll(f.Base(), find, replace)
expectedPath := filepath.Join(f.Dir(), expectedName)
defer os.Remove(expectedPath)
fr := findReplace{find: find, replace: replace}
assertFileExists(t, f)
if err := fr.RenameFile(f); err != nil {
t.Fatalf("RenameFile(%q): %v", f.Path, err)
}
assertPathExistsAfterRename(t, f, expectedPath)
}
// assertNewContentsOfFile ensures that the contents of the file at the given
// path exactly match the desired string.
func assertNewContentsOfFile(t *testing.T, path string, initial string, find string, replace string, want string) {
t.Helper()
got := readOrFatal(t, newFileOrFatal(t, path))
if got != want {
t.Errorf("replace %v with %v in %v, but got %v; want %v", find, replace, initial, got, want)
}
}
func TestReplaceContents(t *testing.T) {
initial := "alpha"
find := "ph"
replace := "f"
want := "alfa"
f := newTestFile(t, "", "*", initial)
defer os.Remove(f.Path)
fr := findReplace{find: find, replace: replace}
if err := fr.ReplaceContents(f); err != nil {
t.Fatalf("ReplaceContents(%q): %v", f.Path, err)
}
assertNewContentsOfFile(t, f.Path, initial, find, replace, want)
}
func TestReplaceContentsEntireFile(t *testing.T) {
initial := "alpha"
find := "alpha"
replace := "beta"
want := "beta"
f := newTestFile(t, "", "*", initial)
defer os.Remove(f.Path)
fr := findReplace{find: find, replace: replace}
if err := fr.ReplaceContents(f); err != nil {
t.Fatalf("ReplaceContents(%q): %v", f.Path, err)
}
assertNewContentsOfFile(t, f.Path, initial, find, replace, want)
}
func TestReplaceContentsMultipleMatchesSingleLine(t *testing.T) {
initial := "alphaalpha"
find := "ph"
replace := "f"
want := "alfaalfa"
f := newTestFile(t, "", "*", initial)
defer os.Remove(f.Path)
fr := findReplace{find: find, replace: replace}
if err := fr.ReplaceContents(f); err != nil {
t.Fatalf("ReplaceContents(%q): %v", f.Path, err)
}
assertNewContentsOfFile(t, f.Path, initial, find, replace, want)
}
func TestReplaceContentsMultipleMatchesMultipleLines(t *testing.T) {
initial := "alpha\nalpha"
find := "ph"
replace := "f"
want := "alfa\nalfa"
f := newTestFile(t, "", "*", initial)
defer os.Remove(f.Path)
fr := findReplace{find: find, replace: replace}
if err := fr.ReplaceContents(f); err != nil {
t.Fatalf("ReplaceContents(%q): %v", f.Path, err)
}
assertNewContentsOfFile(t, f.Path, initial, find, replace, want)
}
func TestReplaceContentsNoMatches(t *testing.T) {
initial := "alpha"
find := "abc"
replace := "xyz"
want := "alpha"
f := newTestFile(t, "", "*", initial)
defer os.Remove(f.Path)
fr := findReplace{find: find, replace: replace}
if err := fr.ReplaceContents(f); err != nil {
t.Fatalf("ReplaceContents(%q): %v", f.Path, err)
}
assertNewContentsOfFile(t, f.Path, initial, find, replace, want)
}
// TestWalkDir_PermissionDeniedSubdirContinues ensures that an unreadable
// subdirectory does not abort the walk. The sibling subtree must still be
// rewritten, and the walker must record an error referencing the failing
// subdirectory.
func TestWalkDir_PermissionDeniedSubdirContinues(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("permission semantics differ on Windows")
}
if os.Geteuid() == 0 {
t.Skip("test requires non-root: chmod 0 directories are still readable as root")
}
root := t.TempDir()
// Build root/a/inside.txt (unreadable parent) and root/b/inside.txt
// (normal). After WalkDir we expect b's file to be rewritten and a's
// directory to surface an error.
denied := filepath.Join(root, "a")
if err := os.Mkdir(denied, 0700); err != nil {
t.Fatalf("Mkdir(%q): %v", denied, err)
}
deniedChild := filepath.Join(denied, "inside.txt")
if err := os.WriteFile(deniedChild, []byte("alpha"), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", deniedChild, err)
}
siblingDir := filepath.Join(root, "b")
if err := os.Mkdir(siblingDir, 0700); err != nil {
t.Fatalf("Mkdir(%q): %v", siblingDir, err)
}
siblingFile := filepath.Join(siblingDir, "inside.txt")
if err := os.WriteFile(siblingFile, []byte("alpha"), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", siblingFile, err)
}
// Remove read+exec from the denied directory only. Restore the bit at
// cleanup so t.TempDir's RemoveAll can succeed.
if err := os.Chmod(denied, 0); err != nil {
t.Fatalf("Chmod(%q, 0): %v", denied, err)
}
t.Cleanup(func() { _ = os.Chmod(denied, 0700) })
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
// The sibling file should have been rewritten despite the denied subtree.
got, err := os.ReadFile(siblingFile)
if err != nil {
t.Fatalf("ReadFile(%q): %v", siblingFile, err)
}
if string(got) != "beta" {
t.Errorf("sibling file contents = %q; want %q (denied sibling aborted the walk)", string(got), "beta")
}
// The walker must have recorded an error referencing the denied subtree.
err = fr.errs.err()
if err == nil {
t.Fatalf("WalkDir succeeded; want error mentioning %q", denied)
}
if !strings.Contains(err.Error(), denied) {
t.Errorf("WalkDir error = %v; want one mentioning %q", err, denied)
}
// errors.Is should walk the joined chain and find the permission error.
if !errors.Is(err, fs.ErrPermission) {
t.Errorf("WalkDir error = %v; want errors.Is(_, fs.ErrPermission) == true", err)
}
}
// TestRenameFile_ReturnsErrorOnExistingDestination ensures a clobbering
// rename is refused (returning an error) rather than crashing the process.
func TestRenameFile_ReturnsErrorOnExistingDestination(t *testing.T) {
tmp := t.TempDir()
src := filepath.Join(tmp, "alpha")
if err := os.WriteFile(src, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", src, err)
}
dst := filepath.Join(tmp, "beta")
if err := os.WriteFile(dst, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", dst, err)
}
f := newFileOrFatal(t, src)
fr := findReplace{find: "alpha", replace: "beta"}
err := fr.RenameFile(f)
if err == nil {
t.Fatalf("RenameFile(%q): err = nil; want an error referencing the occupied destination", src)
}
if !strings.Contains(err.Error(), "beta") {
t.Errorf("RenameFile error = %v; want one mentioning %q", err, "beta")
}
// The source must still be present — RenameFile must not have clobbered
// the destination either.
if _, statErr := os.Stat(src); statErr != nil {
t.Errorf("Stat(%q) after refused rename: %v", src, statErr)
}
if _, statErr := os.Stat(dst); statErr != nil {
t.Errorf("Stat(%q) after refused rename: %v", dst, statErr)
}
}
// TestWalkDir_BadRenameTargetDoesNotAbortSiblings sets up two sibling files
// whose post-rename names would collide with already-existing files. The
// walker must rename what it can, record errors for what it cannot, and not
// abort the rest of the tree.
func TestWalkDir_BadRenameTargetDoesNotAbortSiblings(t *testing.T) {
root := t.TempDir()
// Files that will be renamed alpha -> beta. The "occupied" path already
// has a beta target so its rename must fail. The "free" path has a
// distinct prefix and should succeed.
occupied := filepath.Join(root, "occupied-alpha")
if err := os.WriteFile(occupied, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", occupied, err)
}
occupiedTarget := filepath.Join(root, "occupied-beta")
if err := os.WriteFile(occupiedTarget, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", occupiedTarget, err)
}
free := filepath.Join(root, "free-alpha")
if err := os.WriteFile(free, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", free, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
// The free file should have been renamed.
freeRenamed := filepath.Join(root, "free-beta")
if _, err := os.Stat(freeRenamed); err != nil {
t.Errorf("Stat(%q) after walk: %v (free-alpha should have been renamed despite occupied-alpha's failure)", freeRenamed, err)
}
// The walker must have recorded an error referencing the occupied target.
err := fr.errs.err()
if err == nil {
t.Fatalf("WalkDir succeeded; want a 'refusing to rename' error for occupied-alpha")
}
if !strings.Contains(err.Error(), "occupied-beta") {
t.Errorf("WalkDir error = %v; want one mentioning %q", err, "occupied-beta")
}
}
// TestWriteCleansUpTempFileOnRenameFailure ensures that File.Write does not
// leak a temp file when the rename step fails. It forces the rename to fail
// (after the temp file has been created) by making the destination a
// non-empty directory; os.Rename of a regular file onto a non-empty
// directory returns ENOTEMPTY ("file exists") on Linux regardless of the
// running user, so this exercises the deferred-cleanup path under both root
// and non-root.
func TestWriteCleansUpTempFileOnRenameFailure(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("rename-over-directory semantics differ on Windows")
}
dir := t.TempDir()
target := filepath.Join(dir, "target")
// Create the target as a non-empty directory. Write will succeed in
// creating its tempfile next to it, then fail the rename step.
if err := os.Mkdir(target, 0700); err != nil {
t.Fatalf("Mkdir(%q): %v", target, err)
}
if err := os.WriteFile(filepath.Join(target, "sentinel"), nil, 0600); err != nil {
t.Fatalf("WriteFile sentinel: %v", err)
}
// Snapshot the directory contents before the Write so we can confirm no
// stray files survive afterwards.
beforeEntries, err := os.ReadDir(dir)
if err != nil {
t.Fatalf("ReadDir(%q): %v", dir, err)
}
before := make(map[string]struct{}, len(beforeEntries))
for _, e := range beforeEntries {
before[e.Name()] = struct{}{}
}
// We need f.Mode() to succeed, so prime the cached info.
f := newFileOrFatal(t, target)
if _, err := f.Info(); err != nil {
t.Fatalf("Info(%q): %v", target, err)
}
if err := f.Write("beta"); err == nil {
t.Fatalf("Write succeeded over a non-empty directory; expected an error")
}
// Confirm no new entries (other than the existing target directory)
// linger in the parent.
afterEntries, err := os.ReadDir(dir)
if err != nil {
t.Fatalf("ReadDir(%q): %v", dir, err)
}
for _, e := range afterEntries {
if _, ok := before[e.Name()]; ok {
continue
}
t.Errorf("leftover entry %q in %q after Write failure (tempfile was not cleaned up)", e.Name(), dir)
}
}
// TestRun_ExitsZeroOnSuccess confirms run() returns 0 for a clean walk.
func TestRun_ExitsZeroOnSuccess(t *testing.T) {
dir := t.TempDir()
if err := os.WriteFile(filepath.Join(dir, "alpha.txt"), []byte("alpha"), 0600); err != nil {
t.Fatalf("WriteFile: %v", err)
}
withWorkingDir(t, dir)
var stderr bytes.Buffer
got := run([]string{"find-replace", "alpha", "beta"}, &stderr)
if got != 0 {
t.Errorf("run = %d; want 0 (stderr: %q)", got, stderr.String())
}
}
// TestRun_ExitsNonZeroOnTraversalError confirms run() returns a non-zero
// exit code when any file failed to be processed. We force a failure by
// putting a file whose rename target is occupied.
func TestRun_ExitsNonZeroOnTraversalError(t *testing.T) {
dir := t.TempDir()
src := filepath.Join(dir, "occupied-alpha")
if err := os.WriteFile(src, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", src, err)
}
dst := filepath.Join(dir, "occupied-beta")
if err := os.WriteFile(dst, nil, 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", dst, err)
}
withWorkingDir(t, dir)
var stderr bytes.Buffer
got := run([]string{"find-replace", "alpha", "beta"}, &stderr)
if got == 0 {
t.Errorf("run = 0; want non-zero (stderr: %q)", stderr.String())
}
}
// TestRun_BadArgCountPrintsUsage confirms the usage message goes to stderr
// and the exit code is non-zero.
func TestRun_BadArgCountPrintsUsage(t *testing.T) {
var stderr bytes.Buffer
got := run([]string{"find-replace"}, &stderr)
if got == 0 {
t.Errorf("run = 0; want non-zero")
}
if !strings.Contains(stderr.String(), "Usage: find-replace") {
t.Errorf("stderr = %q; want it to contain a usage line", stderr.String())
}
}
// withWorkingDir chdirs to dir for the duration of the test and restores the
// previous working directory at cleanup.
func withWorkingDir(t *testing.T, dir string) {
t.Helper()
prev, err := os.Getwd()
if err != nil {
t.Fatalf("Getwd: %v", err)
}
if err := os.Chdir(dir); err != nil {
t.Fatalf("Chdir(%q): %v", dir, err)
}
t.Cleanup(func() { _ = os.Chdir(prev) })
}
func CloneRepoToTestDir(b *testing.B, repoUrl string) *File {
b.Helper()
d := newTestDir(b, "", "*")
defer os.Remove(d.Path)
cmd := exec.Command("git", "clone", "--depth=1", "--single-branch", repoUrl, ".")
cmd.Dir = d.Path
out, err := cmd.CombinedOutput()
if err != nil {
b.Errorf("failed to clone repo: %s", out)
}
return d
}
func BenchmarkNova(b *testing.B) {
for n := 0; n < b.N; n++ {
b.StopTimer()
d := CloneRepoToTestDir(b, "git@github.com:openstack/nova.git")
fr := findReplace{find: RandomString(2), replace: RandomString(2)}
b.StartTimer()
fr.WalkDir(d)
}
}
// TestWalkDir_SymlinkToFileOutsideCWDNotFollowed ensures the walker does not
// rewrite a file reached via a symlink whose target lives outside the search
// root. Following the symlink would violate find-replace's documented contract
// ("Searches are performed recursively from the current working directory")
// and is a known privilege-escalation primitive (see issue #2).
func TestWalkDir_SymlinkToFileOutsideCWDNotFollowed(t *testing.T) {
requireSymlinks(t)
// outside holds the file that must NOT be touched by the walk.
outside := t.TempDir()
outsideFile := filepath.Join(outside, "outside.txt")
const outsideContent = "alpha-outside"
if err := os.WriteFile(outsideFile, []byte(outsideContent), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", outsideFile, err)
}
// root is the search root. It contains a real file and a symlink that
// escapes to outsideFile.
root := t.TempDir()
insideFile := filepath.Join(root, "inside.txt")
if err := os.WriteFile(insideFile, []byte("alpha-inside"), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", insideFile, err)
}
escape := filepath.Join(root, "escape.txt")
if err := os.Symlink(outsideFile, escape); err != nil {
t.Fatalf("Symlink(%q, %q): %v", outsideFile, escape, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
if err := fr.errs.err(); err != nil {
t.Errorf("WalkDir reported unexpected error(s): %v", err)
}
// The real file inside the root must have been rewritten.
got, err := os.ReadFile(insideFile)
if err != nil {
t.Fatalf("ReadFile(%q): %v", insideFile, err)
}
if string(got) != "beta-inside" {
t.Errorf("inside.txt = %q; want %q", string(got), "beta-inside")
}
// The symlink target outside the root must NOT have been rewritten.
got, err = os.ReadFile(outsideFile)
if err != nil {
t.Fatalf("ReadFile(%q): %v", outsideFile, err)
}
if string(got) != outsideContent {
t.Errorf("outside.txt = %q; want %q (symlink was followed)", string(got), outsideContent)
}
// The symlink itself should still be present as a symlink (the walker
// should have skipped it, not replaced it with a regular file or renamed
// it).
info, err := os.Lstat(escape)
if err != nil {
t.Fatalf("Lstat(%q) after walk: %v (symlink was removed/renamed)", escape, err)
}
if info.Mode()&fs.ModeSymlink == 0 {
t.Errorf("Lstat(%q).Mode() = %v; want a symlink (was replaced with a regular file)", escape, info.Mode())
}
}
// TestWalkDir_SymlinkToDirOutsideCWDNotTraversed ensures the walker does not
// recurse through a symlink whose target is a directory outside the search
// root. This is the directory variant of the issue #2 reproducer.
func TestWalkDir_SymlinkToDirOutsideCWDNotTraversed(t *testing.T) {
requireSymlinks(t)
// outside is a directory tree we must not touch.
outside := t.TempDir()
outsideFile := filepath.Join(outside, "victim.txt")
const outsideContent = "alpha-outside"
if err := os.WriteFile(outsideFile, []byte(outsideContent), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", outsideFile, err)
}
root := t.TempDir()
escape := filepath.Join(root, "escape")
if err := os.Symlink(outside, escape); err != nil {
t.Fatalf("Symlink(%q, %q): %v", outside, escape, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
if err := fr.errs.err(); err != nil {
t.Errorf("WalkDir reported unexpected error(s): %v", err)
}
// The outside file must NOT have been rewritten.
got, err := os.ReadFile(outsideFile)
if err != nil {
t.Fatalf("ReadFile(%q): %v", outsideFile, err)
}
if string(got) != outsideContent {
t.Errorf("victim.txt = %q; want %q (symlinked directory was traversed)", string(got), outsideContent)
}
// The outside file must NOT have been renamed.
renamed := filepath.Join(outside, "beta-victim.txt")
if _, err := os.Lstat(renamed); err == nil {
t.Errorf("Lstat(%q) succeeded; file inside symlinked dir was renamed", renamed)
}
// The symlink itself should still be present.
if _, err := os.Lstat(escape); err != nil {
t.Errorf("Lstat(%q) after walk: %v (symlink was removed/renamed)", escape, err)
}
}
// TestWalkDir_SymlinkToFileInsideCWDNotFollowed verifies that even when a
// symlink's target is inside the search root, the symlink itself is still
// skipped. The target is still picked up via the normal walker pass over its
// real path, so it is rewritten exactly once — never via the symlink.
func TestWalkDir_SymlinkToFileInsideCWDNotFollowed(t *testing.T) {
requireSymlinks(t)
root := t.TempDir()
real := filepath.Join(root, "real.txt")
if err := os.WriteFile(real, []byte("alpha"), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", real, err)
}
link := filepath.Join(root, "link.txt")
if err := os.Symlink(real, link); err != nil {
t.Fatalf("Symlink(%q, %q): %v", real, link, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
if err := fr.errs.err(); err != nil {
t.Errorf("WalkDir reported unexpected error(s): %v", err)
}
// The real file should be rewritten via the normal pass — exactly once
// (not twice — that is, the symlink was not also followed and rewritten).
got, err := os.ReadFile(real)
if err != nil {
t.Fatalf("ReadFile(%q): %v", real, err)
}
if string(got) != "beta" {
t.Errorf("real.txt = %q; want %q", string(got), "beta")
}
// The symlink should still be a symlink pointing to the (now-rewritten)
// real file. The walker must not have renamed or removed it.
info, err := os.Lstat(link)
if err != nil {
t.Fatalf("Lstat(%q) after walk: %v (symlink was removed/renamed)", link, err)
}
if info.Mode()&fs.ModeSymlink == 0 {
t.Errorf("Lstat(%q).Mode() = %v; want a symlink (was replaced with a regular file)", link, info.Mode())
}
}
// TestWalkDir_BrokenSymlinkSkippedWithoutError ensures a dangling symlink is
// silently skipped, not reported as an error and not "rewritten" or "renamed".
func TestWalkDir_BrokenSymlinkSkippedWithoutError(t *testing.T) {
requireSymlinks(t)
root := t.TempDir()
broken := filepath.Join(root, "alpha-broken")
target := filepath.Join(root, "does-not-exist")
if err := os.Symlink(target, broken); err != nil {
t.Fatalf("Symlink(%q, %q): %v", target, broken, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
if err := fr.errs.err(); err != nil {
t.Errorf("WalkDir reported unexpected error(s) for a broken symlink: %v", err)
}
// The symlink must still be present under its original name (it was not
// renamed alpha-broken -> beta-broken, nor was it followed).
info, err := os.Lstat(broken)
if err != nil {
t.Fatalf("Lstat(%q) after walk: %v (broken symlink was removed/renamed)", broken, err)
}
if info.Mode()&fs.ModeSymlink == 0 {
t.Errorf("Lstat(%q).Mode() = %v; want a symlink (was replaced with a regular file)", broken, info.Mode())
}
// The renamed name should not have been created either.
renamed := filepath.Join(root, "beta-broken")
if _, err := os.Lstat(renamed); err == nil {
t.Errorf("Lstat(%q) succeeded; broken symlink was renamed", renamed)
}
}
// TestWalkDir_RegularFileStillProcessed is a sanity check that the
// symlink-skipping fix does not break the common case for regular files.
func TestWalkDir_RegularFileStillProcessed(t *testing.T) {
root := t.TempDir()
src := filepath.Join(root, "alpha.txt")
if err := os.WriteFile(src, []byte("alpha"), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", src, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
if err := fr.errs.err(); err != nil {
t.Errorf("WalkDir reported unexpected error(s): %v", err)
}
renamed := filepath.Join(root, "beta.txt")
got, err := os.ReadFile(renamed)
if err != nil {
t.Fatalf("ReadFile(%q): %v", renamed, err)
}
if string(got) != "beta" {
t.Errorf("beta.txt = %q; want %q", string(got), "beta")
}
}
// TestWalkDir_RegularDirStillTraversed is the directory variant of the sanity
// check.
func TestWalkDir_RegularDirStillTraversed(t *testing.T) {
root := t.TempDir()
sub := filepath.Join(root, "alpha-dir")
if err := os.Mkdir(sub, 0700); err != nil {
t.Fatalf("Mkdir(%q): %v", sub, err)
}
child := filepath.Join(sub, "alpha.txt")
if err := os.WriteFile(child, []byte("alpha"), 0600); err != nil {
t.Fatalf("WriteFile(%q): %v", child, err)
}
rootFile := newFileOrFatal(t, root)
fr := findReplace{find: "alpha", replace: "beta"}
fr.WalkDir(rootFile)
if err := fr.errs.err(); err != nil {
t.Errorf("WalkDir reported unexpected error(s): %v", err)
}
renamedDir := filepath.Join(root, "beta-dir")
renamedChild := filepath.Join(renamedDir, "beta.txt")
got, err := os.ReadFile(renamedChild)
if err != nil {
t.Fatalf("ReadFile(%q): %v", renamedChild, err)
}
if string(got) != "beta" {
t.Errorf("beta-dir/beta.txt = %q; want %q", string(got), "beta")
}
}