Skip to content

Commit 68410e8

Browse files
authored
Merge pull request #119 from dolittle/validate-collection-name
Validate collection names, upgrade contracts and add specs.
2 parents 4e5e303 + 298d700 commit 68410e8

File tree

32 files changed

+571
-29
lines changed

32 files changed

+571
-29
lines changed

.eslintrc.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module.exports = {
1313
'@typescript-eslint/unified-signatures': 'off',
1414
'import/no-extraneous-dependencies': 'off',
1515
'eol-last': 'error',
16-
'no-multiple-empty-lines': ['error', { 'max': 1, 'maxEOF': 0 }],
16+
'no-multiple-empty-lines': ['error', {'max': 1, 'maxEOF': 0 }],
1717
'header/header': [
1818
2,
1919
'line',
@@ -61,7 +61,7 @@ module.exports = {
6161
'MethodDefinition[accessibility!="private"][value.type="FunctionExpression"]:not(MethodDefinition[value.type="TSEmptyBodyFunctionExpression"] + MethodDefinition[value.type="FunctionExpression"])',
6262
]
6363
}],
64-
64+
6565
'jsdoc/require-returns': ['error', {
6666
'contexts': [
6767
'ArrowFunctionExpression',

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,5 @@ Samples/**/data
6565
Source/**/Distribution
6666
Samples/**/Distribution
6767
Source/**/README.md
68+
69+
.idea

Source/artifacts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"@dolittle/concepts": "6.0.0",
4848
"@dolittle/rudiments": "6.0.0",
4949
"@dolittle/types": "6.0.0",
50-
"@dolittle/runtime.contracts": "6.6.0-sam.2"
50+
"@dolittle/runtime.contracts": "6.6.0-sam.3"
5151
},
5252
"devDependencies": {
5353
"@types/is-natural-number": "^4.0.0"

Source/embeddings/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
},
4646
"dependencies": {
4747
"@dolittle/concepts": "6.0.0",
48-
"@dolittle/contracts": "6.6.0-sam.2",
48+
"@dolittle/contracts": "6.6.0-sam.3",
4949
"@dolittle/rudiments": "6.0.0",
50-
"@dolittle/runtime.contracts": "6.6.0-sam.2",
50+
"@dolittle/runtime.contracts": "6.6.0-sam.3",
5151
"@dolittle/sdk.artifacts": "22.2.0-sam.3",
5252
"@dolittle/sdk.common": "22.2.0-sam.3",
5353
"@dolittle/sdk.dependencyinversion": "22.2.0-sam.3",

Source/eventHorizon/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"dependencies": {
4747
"@dolittle/concepts": "6.0.0",
4848
"@dolittle/rudiments": "6.0.0",
49-
"@dolittle/runtime.contracts": "6.6.0-sam.2",
49+
"@dolittle/runtime.contracts": "6.6.0-sam.3",
5050
"@dolittle/sdk.events": "22.2.0-sam.3",
5151
"@dolittle/sdk.execution": "22.2.0-sam.3",
5252
"@dolittle/sdk.protobuf": "22.2.0-sam.3",

Source/events.filtering/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
},
4646
"dependencies": {
4747
"@dolittle/concepts": "6.0.0",
48-
"@dolittle/contracts": "6.6.0-sam.2",
48+
"@dolittle/contracts": "6.6.0-sam.3",
4949
"@dolittle/rudiments": "6.0.0",
50-
"@dolittle/runtime.contracts": "6.6.0-sam.2",
50+
"@dolittle/runtime.contracts": "6.6.0-sam.3",
5151
"@dolittle/sdk.common": "22.2.0-sam.3",
5252
"@dolittle/sdk.dependencyinversion": "22.2.0-sam.3",
5353
"@dolittle/sdk.events": "22.2.0-sam.3",

Source/events.handling/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
},
4646
"dependencies": {
4747
"@dolittle/concepts": "6.0.0",
48-
"@dolittle/contracts": "6.6.0-sam.2",
48+
"@dolittle/contracts": "6.6.0-sam.3",
4949
"@dolittle/rudiments": "6.0.0",
50-
"@dolittle/runtime.contracts": "6.6.0-sam.2",
50+
"@dolittle/runtime.contracts": "6.6.0-sam.3",
5151
"@dolittle/sdk.artifacts": "22.2.0-sam.3",
5252
"@dolittle/sdk.common": "22.2.0-sam.3",
5353
"@dolittle/sdk.dependencyinversion": "22.2.0-sam.3",

Source/events.processing/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
},
4646
"dependencies": {
4747
"@dolittle/concepts": "6.0.0",
48-
"@dolittle/contracts": "6.6.0-sam.2",
48+
"@dolittle/contracts": "6.6.0-sam.3",
4949
"@dolittle/rudiments": "6.0.0",
50-
"@dolittle/runtime.contracts": "6.6.0-sam.2",
50+
"@dolittle/runtime.contracts": "6.6.0-sam.3",
5151
"@dolittle/sdk.common": "22.2.0-sam.3",
5252
"@dolittle/sdk.dependencyinversion": "22.2.0-sam.3",
5353
"@dolittle/sdk.execution": "22.2.0-sam.3",

Source/events/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
},
4646
"dependencies": {
4747
"@dolittle/concepts": "6.0.0",
48-
"@dolittle/contracts": "6.6.0-sam.2",
48+
"@dolittle/contracts": "6.6.0-sam.3",
4949
"@dolittle/rudiments": "6.0.0",
50-
"@dolittle/runtime.contracts": "6.6.0-sam.2",
50+
"@dolittle/runtime.contracts": "6.6.0-sam.3",
5151
"@dolittle/sdk.artifacts": "22.2.0-sam.3",
5252
"@dolittle/sdk.execution": "22.2.0-sam.3",
5353
"@dolittle/sdk.protobuf": "22.2.0-sam.3",

Source/projections/Builders/Copies/CopyToMongoDBBuilder.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,12 @@ export class CopyToMongoDBBuilder<T> extends ICopyToMongoDBBuilder<T> {
5959
return undefined;
6060
}
6161

62+
const [collectionNameIsValid, collectionNameValidationError] = this._collectionName.isValid();
63+
if (!collectionNameIsValid) {
64+
results.addFailure(`Cannot create MongoDB read model copies. ${collectionNameValidationError?.message}`);
65+
return undefined;
66+
}
67+
6268
return new MongoDBCopies(true, this._collectionName, this.buildPropertyConversions());
6369
}
6470

0 commit comments

Comments
 (0)