From 1625cb87c25ef03ecabbcd5e0965a5de05fdd1bb Mon Sep 17 00:00:00 2001 From: Kathy Tran Date: Thu, 5 Dec 2024 17:07:11 -0500 Subject: [PATCH 1/5] Display task container names --- cloud-watch-to-slack-testing/deployment/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cloud-watch-to-slack-testing/deployment/index.js b/cloud-watch-to-slack-testing/deployment/index.js index 3b2c448..8ccfc0e 100644 --- a/cloud-watch-to-slack-testing/deployment/index.js +++ b/cloud-watch-to-slack-testing/deployment/index.js @@ -258,6 +258,8 @@ function ecsTaskStateChangeMessageText(message) { const taskArn = message?.detail?.taskArn; const lastStatus = message?.detail?.lastStatus; let messageText = `Task ${taskArn} is now ${lastStatus}`; + const taskContainers = message?.detail?.containers?.map((container) => container.name).join(', '); + messageText += `\nTask containers: ${taskContainers}`; ["startedAt", "stoppedAt", "stoppedReason"].forEach((name) => { const value = message?.detail?.[name]; if (value != undefined) { From ab4abace7993899827b2a51f676eda218883ed84 Mon Sep 17 00:00:00 2001 From: Kathy Tran Date: Fri, 6 Dec 2024 14:48:30 -0500 Subject: [PATCH 2/5] Fix lint --- cloud-watch-to-slack-testing/deployment/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cloud-watch-to-slack-testing/deployment/index.js b/cloud-watch-to-slack-testing/deployment/index.js index 8ccfc0e..48a74c7 100644 --- a/cloud-watch-to-slack-testing/deployment/index.js +++ b/cloud-watch-to-slack-testing/deployment/index.js @@ -258,7 +258,9 @@ function ecsTaskStateChangeMessageText(message) { const taskArn = message?.detail?.taskArn; const lastStatus = message?.detail?.lastStatus; let messageText = `Task ${taskArn} is now ${lastStatus}`; - const taskContainers = message?.detail?.containers?.map((container) => container.name).join(', '); + const taskContainers = message?.detail?.containers + ?.map((container) => container.name) + .join(", "); messageText += `\nTask containers: ${taskContainers}`; ["startedAt", "stoppedAt", "stoppedReason"].forEach((name) => { const value = message?.detail?.[name]; From 7773d6f5dc8cdff8d498007deef5851b94167fa3 Mon Sep 17 00:00:00 2001 From: Kathy Tran Date: Tue, 10 Dec 2024 09:35:37 -0500 Subject: [PATCH 3/5] Simplify --- cloud-watch-to-slack-testing/deployment/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cloud-watch-to-slack-testing/deployment/index.js b/cloud-watch-to-slack-testing/deployment/index.js index 48a74c7..e27124b 100644 --- a/cloud-watch-to-slack-testing/deployment/index.js +++ b/cloud-watch-to-slack-testing/deployment/index.js @@ -261,7 +261,7 @@ function ecsTaskStateChangeMessageText(message) { const taskContainers = message?.detail?.containers ?.map((container) => container.name) .join(", "); - messageText += `\nTask containers: ${taskContainers}`; + messageText += `\nContainers: ${taskContainers}`; ["startedAt", "stoppedAt", "stoppedReason"].forEach((name) => { const value = message?.detail?.[name]; if (value != undefined) { From 57572ea0f06a62d4c3a2c448d73f65fbc3018a73 Mon Sep 17 00:00:00 2001 From: Kathy Tran Date: Wed, 11 Dec 2024 10:35:17 -0500 Subject: [PATCH 4/5] PR feedback --- cloud-watch-to-slack-testing/deployment/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cloud-watch-to-slack-testing/deployment/index.js b/cloud-watch-to-slack-testing/deployment/index.js index e27124b..bc18d53 100644 --- a/cloud-watch-to-slack-testing/deployment/index.js +++ b/cloud-watch-to-slack-testing/deployment/index.js @@ -260,7 +260,7 @@ function ecsTaskStateChangeMessageText(message) { let messageText = `Task ${taskArn} is now ${lastStatus}`; const taskContainers = message?.detail?.containers ?.map((container) => container.name) - .join(", "); + ?.join(", "); messageText += `\nContainers: ${taskContainers}`; ["startedAt", "stoppedAt", "stoppedReason"].forEach((name) => { const value = message?.detail?.[name]; From ca71d0fd727ea5d82f5bb2122defd8afabd81687 Mon Sep 17 00:00:00 2001 From: Kathy Tran Date: Wed, 11 Dec 2024 10:58:11 -0500 Subject: [PATCH 5/5] Check if array --- cloud-watch-to-slack-testing/deployment/index.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/cloud-watch-to-slack-testing/deployment/index.js b/cloud-watch-to-slack-testing/deployment/index.js index bc18d53..38c8d6f 100644 --- a/cloud-watch-to-slack-testing/deployment/index.js +++ b/cloud-watch-to-slack-testing/deployment/index.js @@ -258,10 +258,13 @@ function ecsTaskStateChangeMessageText(message) { const taskArn = message?.detail?.taskArn; const lastStatus = message?.detail?.lastStatus; let messageText = `Task ${taskArn} is now ${lastStatus}`; - const taskContainers = message?.detail?.containers - ?.map((container) => container.name) - ?.join(", "); - messageText += `\nContainers: ${taskContainers}`; + const taskContainers = message?.detail?.containers; + if (Array.isArray(taskContainers)) { + const taskContainerNames = taskContainers + ?.map((container) => container.name) + ?.join(", "); + messageText += `\nContainers: ${taskContainerNames}`; + } ["startedAt", "stoppedAt", "stoppedReason"].forEach((name) => { const value = message?.detail?.[name]; if (value != undefined) {