From a2b9691b7877d47a1f9cbb7a8f34cd8cc9305667 Mon Sep 17 00:00:00 2001 From: Robert Dima Date: Mon, 11 May 2026 20:19:49 +0300 Subject: [PATCH] Fix unreliable DnnMvcHandler.DisableMvcResponseHeader --- DNN Platform/DotNetNuke.Web.Mvc/DnnMvcHandler.cs | 2 +- .../Framework/Modules/ModuleApplication.cs | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/DNN Platform/DotNetNuke.Web.Mvc/DnnMvcHandler.cs b/DNN Platform/DotNetNuke.Web.Mvc/DnnMvcHandler.cs index 5f37f95e7c5..94b3bd55b1e 100644 --- a/DNN Platform/DotNetNuke.Web.Mvc/DnnMvcHandler.cs +++ b/DNN Platform/DotNetNuke.Web.Mvc/DnnMvcHandler.cs @@ -130,7 +130,7 @@ private ModuleRequestContext GetModuleRequestContext(HttpContextBase httpContext { HttpContext = httpContext, ModuleContext = moduleContext, - ModuleApplication = new ModuleApplication(this.RequestContext, DisableMvcResponseHeader) + ModuleApplication = new ModuleApplication(this.RequestContext) { ModuleName = desktopModule.ModuleName, FolderPath = desktopModule.FolderName, diff --git a/DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ModuleApplication.cs b/DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ModuleApplication.cs index 59daa7a514d..327f53eda43 100644 --- a/DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ModuleApplication.cs +++ b/DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ModuleApplication.cs @@ -32,20 +32,23 @@ public class ModuleApplication private bool initialized; public ModuleApplication() - : this(null, false) + : this(null) { } public ModuleApplication(bool disableMvcResponseHeader) - : this(null, disableMvcResponseHeader) + : this(null) { } public ModuleApplication(RequestContext requestContext, bool disableMvcResponseHeader) + : this(requestContext) { - this.RequestContext = requestContext; + } - DisableMvcResponseHeader = disableMvcResponseHeader; + public ModuleApplication(RequestContext requestContext) + { + this.RequestContext = requestContext; // ReSharper disable once DoNotCallOverridableMethodsInConstructor this.ControllerFactory = Globals.GetCurrentServiceProvider().GetRequiredService(); @@ -70,8 +73,6 @@ public ModuleApplication(RequestContext requestContext, bool disableMvcResponseH public ViewEngineCollection ViewEngines { get; set; } - private static bool DisableMvcResponseHeader { get; set; } - public virtual ModuleRequestResult ExecuteRequest(ModuleRequestContext context) { this.EnsureInitialized(); @@ -164,7 +165,7 @@ protected internal virtual void Init() protected internal virtual void AddVersionHeader(HttpContextBase httpContext) { - if (!DisableMvcResponseHeader) + if (!DnnMvcHandler.DisableMvcResponseHeader) { httpContext.Response.AppendHeader(MvcVersionHeaderName, MvcVersion); }