fix(parser): Accept short hand package syntax (:a) in subpackages too

The hack that we had in place to accept this did not properly recurse
in arrays and associative array, the former causing the issue shown
on the linked pull request. Additionally, add a comprehensive unittest
as found in an old issue (1615) as it covers both cases.

Author: Geod24

source/dub/recipe/packagerecipe.d

@@ -790,22 +790,32 @@ unittest { // issue #1407 - duplicate main source file
  *
  * TODO: Remove the special case in the parser and remove this hack.
  */
-package void fixDependenciesNames (T) (string root, ref T aggr) nothrow
+package void fixDependenciesNames (T) (string root, ref T aggr)
 {
-	static foreach (idx, FieldRef; T.tupleof) {
-		static if (is(immutable typeof(FieldRef) == immutable RecipeDependencyAA)) {
-			string[] toReplace;
-			foreach (key; aggr.tupleof[idx].byKey)
-				if (key.length && key[0] == ':')
-					toReplace ~= key;
-			foreach (k; toReplace) {
-				aggr.tupleof[idx][root ~ k] = aggr.tupleof[idx][k];
-				aggr.tupleof[idx].data.remove(k);
-			}
-		}
-		else static if (is(typeof(FieldRef) == struct))
-			fixDependenciesNames(root, aggr.tupleof[idx]);
-	}
+	static foreach (idx, FieldRef; T.tupleof)
+        fixFieldDependenciesNames(root, aggr.tupleof[idx]);
+}
+
+/// Ditto
+private void fixFieldDependenciesNames (Field) (string root, ref Field field)
+{
+    static if (is(immutable Field == immutable RecipeDependencyAA)) {
+        string[] toReplace;
+        foreach (key; field.byKey)
+            if (key.length && key[0] == ':')
+                toReplace ~= key;
+        foreach (k; toReplace) {
+            field[root ~ k] = field[k];
+            field.data.remove(k);
+        }
+    } else static if (is(Field == struct))
+        fixDependenciesNames(root, field);
+    else static if (is(Field : Elem[], Elem))
+        foreach (ref entry; field)
+            fixFieldDependenciesNames(root, entry);
+    else static if (is(Field : Value[Key], Value, Key))
+        foreach (key, ref value; field)
+            fixFieldDependenciesNames(root, value);
 }
 
 /**

source/dub/test/subpackages.d

@@ -60,3 +60,18 @@ unittest
     assert(dub.project.getDependency("b:a", true), "Missing 'b:a' dependency");
     assert(dub.project.getDependency("c:a", true), "Missing 'c:a' dependency");
 }
+
+// https://github.com/dlang/dub/issues/1615
+// https://github.com/dlang/dub/pull/2972
+unittest
+{
+    scope dub = new TestDub((scope Filesystem root) {
+        root.writeFile(TestDub.ProjectPath ~ "dub.json",
+            `{"name": "t9",
+"subPackages":[{"name": "a","dependencies": {":b": "*"}},{"name": "b"}],
+"dependencies": {":a": "*",":b": "*"}}`);
+    });
+    dub.loadPackage();
+
+    assert(dub.project.hasAllDependencies(), "project has missing dependencies");
+}