Allow falsy values to be returned from ChoiceOption

mgd722 · mgd722 · commit 6cc349b868af · 2020-12-02T15:57:21.000-07:00
diff --git a/src/models/QuestionModel.js b/src/models/QuestionModel.js
@@ -46,7 +46,9 @@ export class ChoiceOption {
   }
 
   choiceValue() {
-    return this.value || this.label
+    // returns the value if it's anything other than the default (an empty string).
+    // returns label if the value has not been set.
+    return this.value !== '' ? this.value : this.label
   }
 
   toggle() {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,9 @@ export class ChoiceOption {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`choiceValue() {`
`49`		`- return this.value \|\| this.label`
	`49`	`+ // returns the value if it's anything other than the default (an empty string).`
	`50`	`+ // returns label if the value has not been set.`
	`51`	`+ return this.value !== '' ? this.value : this.label`
`50`	`52`	`}`
`51`	`53`
`52`	`54`	`toggle() {`