reflect feedbacks

Author: DevTGHa

src/designer_plugin/api.py

@@ -201,7 +201,7 @@ async def d3_api_aregister_module(
             timeout=aiohttp.ClientTimeout(timeout_sec) if timeout_sec else None,
         )
     except Exception as e:
-        raise Exception(f"Failed to register module '{payload.moduleName}") from e
+        raise Exception(f"Failed to register module: '{payload.moduleName}'") from e
 
     plugin_response: PluginRegisterResponse = PluginRegisterResponse.model_validate(
         response

src/designer_plugin/d3sdk/ast_utils.py

@@ -59,18 +59,13 @@ def filter_base_classes(class_node: ast.ClassDef) -> None:
 
 
 def filter_init_args(class_node: ast.ClassDef) -> list[str]:
-    """Remove excluded arguments from __init__ method and extract parameter names.
-
-    This function modifies the class_node in-place by:
-    1. Removing excluded parameters from __init__ signature
-    2. Removing excluded arguments from super().__init__() calls
-    3. Returning the list of remaining parameter names (excluding 'self')
+    """Extract parameter names from the __init__ method of a class.
 
     Args:
         class_node: The class definition node to process
 
     Returns:
-        List of parameter names that remain after filtering (excluding 'self')
+        List of parameter names from __init__ (excluding 'self'), or empty list if no __init__ found
     """
     for node in class_node.body:
         if not isinstance(node, ast.FunctionDef):

src/designer_plugin/d3sdk/client.py

@@ -231,7 +231,7 @@ def __new__(cls, name: str, bases: tuple[type, ...], attrs: dict[str, Any]) -> t
         attrs["source_code_py27"] = f"{ast.unparse(class_node)}"
 
         # Wrap all user-defined public methods to execute remotely via D3 API
-        # Skip private methods (_*) and internal framework methods
+        # Skip internal framework methods
         for attr_name, attr_value in attrs.items():
             if callable(attr_value) and not attr_name.startswith("__"):
                 attrs[attr_name] = create_d3_plugin_method_wrapper(
@@ -318,7 +318,7 @@ def get_surface_uid(self, surface_name: str) -> dict[str, str]:
 
     # Use as sync context manager
     with plugin.session("localhost", 80):
-        result = await plugin.get_surface_uid("surface 1")
+        result = plugin.get_surface_uid("surface 1")
     ```
     Attributes:
         instance_code: The code used to instantiate the plugin remotely (set on init)

src/designer_plugin/d3sdk/function.py

@@ -189,7 +189,8 @@ def _args_to_assign(self, *args: Any, **kwargs: Any) -> str:
             String containing variable assignment statements, one per line.
         """
         args_parts = [
-            f"{self._function_info.args[i]}={repr(arg)}" for i, arg in enumerate(args)
+            f"{param}={repr(arg)}"
+            for param, arg in zip(self._function_info.args, args, strict=False)
         ]
         kwargs_parts = [f"{name}={repr(value)}" for name, value in kwargs.items()]
         return "\n".join(args_parts + kwargs_parts)

src/designer_plugin/models.py

@@ -59,12 +59,14 @@ class PluginResponse(BaseModel, Generic[RetType]):
     @field_validator("returnValue", mode="before")
     @classmethod
     def parse_returnValue(cls, v: Any) -> Any:
-        if isinstance(v, str):
-            if v == "null":
-                return None
-            else:
-                return json.loads(v)
-        return v
+        if not isinstance(v, str):
+            return v
+        if v == "null":
+            return None
+        try:
+            return json.loads(v)
+        except json.JSONDecodeError:
+            return v
 
     def returnCastValue(self, castType: type[RetCastType]) -> RetCastType:
         """Validate and cast the return value to the specified type.

tests/test_core.py

@@ -3,6 +3,8 @@
 Copyright (c) 2025 Disguise Technologies ltd
 """
 
+import pytest
+
 from designer_plugin.d3sdk.function import (
     D3Function,
     D3PythonScript,
@@ -290,3 +292,30 @@ def test_func(a: int, b: int = 10) -> int:
         assert "a=5" in payload.script
         assert "b=15" in payload.script
         assert "return a + b" in payload.script
+
+    def test_d3pythonscript_args_to_assign_with_extra_args(self):
+        """Test that _args_to_assign handles extra arguments gracefully.
+
+        This test will fail with the enumerate/indexing implementation:
+            args_parts = [f"{self._function_info.args[i]}={repr(arg)}" for i, arg in enumerate(args)]
+
+        But will pass with the zip implementation:
+            args_parts = [f"{param}={repr(arg)}" for param, arg in zip(self._function_info.args, args)]
+
+        The enumerate version causes IndexError when len(args) > len(function parameters).
+        The zip version stops at the shorter sequence length.
+        """
+        @d3pythonscript
+        def test_func(a: int, b: int) -> int:
+            return a + b
+
+        # This function has 2 parameters but we're passing 3 arguments
+        # The first implementation will crash with IndexError
+        # The second implementation will silently ignore the extra argument
+        result = test_func._args_to_assign(1, 2, 3)
+
+        # Should only contain assignments for the defined parameters
+        assert "a=1" in result
+        assert "b=2" in result
+        # The extra argument should be silently ignored by the zip implementation
+        assert result.count("=") == 2  # Only 2 assignments