From 979e8b3dc561ea7419eeabbee8e81e62518132cc Mon Sep 17 00:00:00 2001 From: Ariel Rokem Date: Tue, 13 Apr 2021 15:54:34 -0700 Subject: [PATCH 1/3] Fixes typo in reference to dockerfile path. --- .github/workflows/dockerbuild.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dockerbuild.yml b/.github/workflows/dockerbuild.yml index eeb85f2..e4e30a7 100644 --- a/.github/workflows/dockerbuild.yml +++ b/.github/workflows/dockerbuild.yml @@ -37,6 +37,6 @@ jobs: password: ${{secrets.CR_PAT}} - name: Build and push docker image - run: sh ./Docker/dockerbuild.sh \ + run: sh ./docker/dockerbuild.sh \ "${{github.sha}}" \ "dipy" From 3f969f8874fa6bf8b87c50e440bb3b28ce9774b3 Mon Sep 17 00:00:00 2001 From: Ariel Rokem Date: Tue, 13 Apr 2021 15:56:26 -0700 Subject: [PATCH 2/3] Pull requests are against `master` branch, not `main`. --- .github/workflows/dockerbuild.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dockerbuild.yml b/.github/workflows/dockerbuild.yml index e4e30a7..48fc687 100644 --- a/.github/workflows/dockerbuild.yml +++ b/.github/workflows/dockerbuild.yml @@ -6,7 +6,7 @@ on: - 'master' pull_request: branches: - - main + - master jobs: build: From 2ec8d539fc97a25418834f5e5cb022df22133ffb Mon Sep 17 00:00:00 2001 From: Ariel Rokem Date: Tue, 13 Apr 2021 16:02:22 -0700 Subject: [PATCH 3/3] Maybe the user name needs to be Ariel's username. --- .github/workflows/dockerbuild.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dockerbuild.yml b/.github/workflows/dockerbuild.yml index 48fc687..71a9d42 100644 --- a/.github/workflows/dockerbuild.yml +++ b/.github/workflows/dockerbuild.yml @@ -33,7 +33,7 @@ jobs: uses: docker/login-action@v1 with: registry: ghcr.io - username: dipy + username: arokem password: ${{secrets.CR_PAT}} - name: Build and push docker image