Merge pull request #1032 from tautschnig/empty-cleanup

Use empty() instead of size()==0, size()<1

Author: kroening

src/ansi-c/c_typecheck_expr.cpp

@@ -2566,7 +2566,7 @@ exprt c_typecheck_baset::do_special_functions(
     // http://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Atomic-Builtins.html
 
     // adjust return type of function to match pointer subtype
-    if(expr.arguments().size()<1)
+    if(expr.arguments().empty())
     {
       err_location(f_op);
       error() << "__sync_* primitives take as least one argument" << eom;

src/ansi-c/expr2c.cpp

@@ -2588,7 +2588,7 @@ std::string expr2ct::convert_code_switch(
   const codet &src,
   unsigned indent)
 {
-  if(src.operands().size()<1)
+  if(src.operands().empty())
   {
     unsigned precedence;
     return convert_norep(src, precedence);

src/clobber/clobber_parse_options.cpp

@@ -192,7 +192,7 @@ bool clobber_parse_optionst::get_goto_program(
   const optionst &options,
   goto_functionst &goto_functions)
 {
-  if(cmdline.args.size()==0)
+  if(cmdline.args.empty())
   {
     error() << "Please provide a program to verify" << eom;
     return true;

src/cpp/cpp_typecheck_compound_type.cpp

@@ -466,7 +466,7 @@ void cpp_typecheckt::typecheck_compound_declarator(
         {
           is_virtual=true;
           const code_typet &code_type=to_code_type(comp.type());
-          assert(code_type.parameters().size()>0);
+          assert(!code_type.parameters().empty());
           const typet &pointer_type=code_type.parameters()[0].type();
           assert(pointer_type.id()==ID_pointer);
           virtual_bases.insert(pointer_type.subtype().get(ID_identifier));

src/cpp/cpp_typecheck_conversions.cpp

@@ -574,13 +574,13 @@ bool cpp_typecheckt::standard_conversion_pointer_to_member(
        expr.type().subtype().id()==ID_code)
     {
       code_typet code1=to_code_type(expr.type().subtype());
-      assert(code1.parameters().size()>0);
+      assert(!code1.parameters().empty());
       code_typet::parametert this1=code1.parameters()[0];
       assert(this1.get(ID_C_base_name)==ID_this);
       code1.parameters().erase(code1.parameters().begin());
 
       code_typet code2=to_code_type(type.subtype());
-      assert(code2.parameters().size()>0);
+      assert(!code2.parameters().empty());
       code_typet::parametert this2=code2.parameters()[0];
       assert(this2.get(ID_C_base_name)==ID_this);
       code2.parameters().erase(code2.parameters().begin());

src/cpp/cpp_typecheck_expr.cpp

@@ -1431,7 +1431,7 @@ void cpp_typecheckt::typecheck_expr_cpp_name(
       // http://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Atomic-Builtins.html
 
       // adjust return type of function to match pointer subtype
-      if(fargs.operands.size()<1)
+      if(fargs.operands.empty())
       {
         error().source_location=source_location;
         error() << "__sync_* primitives take as least one argument"

src/goto-cc/compile.cpp

@@ -102,13 +102,13 @@ bool compilet::doit()
     return true;
   }
 
-  if(mode==LINK_LIBRARY && source_files.size()>0)
+  if(mode==LINK_LIBRARY && !source_files.empty())
   {
     error() << "cannot link source files" << eom;
     return true;
   }
 
-  if(mode==PREPROCESS_ONLY && object_files.size()>0)
+  if(mode==PREPROCESS_ONLY && !object_files.empty())
   {
     error() << "cannot preprocess object files" << eom;
     return true;
@@ -117,7 +117,7 @@ bool compilet::doit()
   const unsigned warnings_before=
     get_message_handler().get_message_count(messaget::M_WARNING);
 
-  if(source_files.size()>0)
+  if(!source_files.empty())
     if(compile())
       return true;
 
@@ -346,7 +346,7 @@ bool compilet::link()
   convert_symbols(compiled_functions);
 
   // parse object files
-  while(object_files.size()>0)
+  while(!object_files.empty())
   {
     std::string file_name=object_files.front();
     object_files.pop_front();

src/goto-cc/xml_binaries/xml_goto_function.cpp

@@ -33,6 +33,5 @@ void convert(const xmlt &xml, goto_functionst::goto_functiont &function)
 {
   function.body.clear();
   convert(xml, function.body);
-  function.body_available = function.body.instructions.size()>0;
   // don't forget to fix the functions type via the symbol table!
 }

src/goto-cc/xml_binaries/xml_goto_function_hashing.cpp

@@ -38,6 +38,5 @@ void xml_goto_function_convertt::convert(
   xml_goto_program_convertt gpconverter(ireps_container);
   function.body.clear();
   gpconverter.convert(xml, function.body);
-  function.body_available = function.body.instructions.size()>0;
   // don't forget to fix the functions type via the symbol table!
 }

src/goto-cc/xml_binaries/xml_symbol.cpp

@@ -54,7 +54,7 @@ void convert(const symbolt &sym, xmlt &root)
   flags.new_element("base_name").data=id2string(sym.base_name);
   flags.new_element("module").data=id2string(sym.module);
 
-  if(sym.pretty_name.size()>0)
+  if(!sym.pretty_name.empty())
     flags.new_element("pretty_name").data=id2string(sym.pretty_name);
 
   xmlt &xmlloc = xmlsym.new_element("location");