Merge pull request #7364 from martin-cs/tidy/vsd-internals-1

Remove an unused constructor from the interface of abstract_objectt

Author: martin-cs

src/analyses/variable-sensitivity/abstract_aggregate_object.h

@@ -30,12 +30,6 @@ class abstract_aggregate_objectt : public abstract_objectt,
                                    public abstract_aggregate_tag
 {
 public:
-  explicit abstract_aggregate_objectt(const typet &type)
-    : abstract_objectt(type)
-  {
-    PRECONDITION(type.id() == aggregate_traitst::TYPE_ID());
-  }
-
   abstract_aggregate_objectt(const typet &type, bool tp, bool bttm)
     : abstract_objectt(type, tp, bttm)
   {

src/analyses/variable-sensitivity/abstract_object.cpp

@@ -16,11 +16,6 @@
 
 #include "abstract_object.h"
 
-abstract_objectt::abstract_objectt(const typet &type)
-  : t(type), bottom(false), top(true)
-{
-}
-
 abstract_objectt::abstract_objectt(const typet &type, bool top, bool bottom)
   : t(type), bottom(bottom), top(top)
 {
@@ -35,15 +30,6 @@ abstract_objectt::abstract_objectt(
 {
 }
 
-abstract_objectt::abstract_objectt(
-  const typet &type,
-  const exprt &expr,
-  const abstract_environmentt &environment,
-  const namespacet &ns)
-  : t(type), bottom(false), top(true)
-{
-}
-
 const typet &abstract_objectt::type() const
 {
   return t;

src/analyses/variable-sensitivity/abstract_object.h

@@ -72,9 +72,6 @@ using abstract_object_visitedt = std::set<abstract_object_pointert>;
 class abstract_objectt : public std::enable_shared_from_this<abstract_objectt>
 {
 public:
-  /// \param type: the type the abstract_object is representing
-  explicit abstract_objectt(const typet &type);
-
   /// Start the abstract object at either top or bottom or neither
   /// Asserts if both top and bottom are true
   ///
@@ -95,19 +92,6 @@ class abstract_objectt : public std::enable_shared_from_this<abstract_objectt>
     const abstract_environmentt &environment,
     const namespacet &ns);
 
-  /// Ctor for building object of types that differ from the types of input
-  /// expressions
-  ///
-  /// \param type explicitly declared type the resulting object should have
-  /// \param expr expression used to build the object
-  /// \param environment abstract environment to evaluate the expression
-  /// \param ns namespace to uncover names inside the expression
-  abstract_objectt(
-    const typet &type,
-    const exprt &expr,
-    const abstract_environmentt &environment,
-    const namespacet &ns);
-
   virtual ~abstract_objectt()
   {
   }

src/analyses/variable-sensitivity/abstract_pointer_object.cpp

@@ -13,12 +13,6 @@
 
 #include "abstract_object_statistics.h"
 
-abstract_pointer_objectt::abstract_pointer_objectt(const typet &t)
-  : abstract_objectt(t)
-{
-  PRECONDITION(t.id() == ID_pointer);
-}
-
 abstract_pointer_objectt::abstract_pointer_objectt(
   const typet &type,
   bool top,

src/analyses/variable-sensitivity/abstract_pointer_object.h

@@ -21,9 +21,6 @@ class abstract_pointer_objectt : public abstract_objectt,
                                  public abstract_pointer_tag
 {
 public:
-  /// \param type: the type the abstract_object is representing
-  explicit abstract_pointer_objectt(const typet &type);
-
   /// Start the abstract object at either top or bottom or neither
   /// Asserts if both top and bottom are true
   ///

src/analyses/variable-sensitivity/abstract_value_object.h

@@ -240,10 +240,6 @@ class abstract_value_objectt : public abstract_objectt,
                                public abstract_value_tag
 {
 public:
-  explicit abstract_value_objectt(const typet &type) : abstract_objectt(type)
-  {
-  }
-
   abstract_value_objectt(const typet &type, bool tp, bool bttm)
     : abstract_objectt(type, tp, bttm)
   {

src/analyses/variable-sensitivity/constant_abstract_value.cpp

@@ -37,11 +37,6 @@ make_constant_index_range(const exprt &val)
   return util_make_unique<constant_index_ranget>(val);
 }
 
-constant_abstract_valuet::constant_abstract_valuet(const typet &t)
-  : abstract_value_objectt(t), value()
-{
-}
-
 constant_abstract_valuet::constant_abstract_valuet(const exprt &e)
   : abstract_value_objectt(e.type(), false, false), value(e)
 {

src/analyses/variable-sensitivity/constant_abstract_value.h

@@ -19,7 +19,6 @@
 class constant_abstract_valuet : public abstract_value_objectt
 {
 public:
-  explicit constant_abstract_valuet(const typet &t);
   explicit constant_abstract_valuet(const exprt &t);
   constant_abstract_valuet(const typet &t, bool tp, bool bttm);
   constant_abstract_valuet(

src/analyses/variable-sensitivity/constant_pointer_abstract_object.cpp

@@ -20,13 +20,6 @@
 
 #include <ostream>
 
-constant_pointer_abstract_objectt::constant_pointer_abstract_objectt(
-  const typet &type)
-  : abstract_pointer_objectt(type)
-{
-  PRECONDITION(type.id() == ID_pointer);
-}
-
 constant_pointer_abstract_objectt::constant_pointer_abstract_objectt(
   const typet &type,
   bool top,

src/analyses/variable-sensitivity/constant_pointer_abstract_object.h

@@ -23,9 +23,6 @@ class constant_pointer_abstract_objectt : public abstract_pointer_objectt
     constant_pointer_abstract_pointert;
 
 public:
-  /// \param type: the type the abstract_object is representing
-  explicit constant_pointer_abstract_objectt(const typet &type);
-
   /// \param type: the type the abstract_object is representing
   /// \param top: is the abstract_object starting as top
   /// \param bottom: is the abstract_object starting as bottom