Merge pull request #5400 from hannes-steffenhagen-diffblue/fix/dangling-reference-in-unit-tests

hannes-steffenhagen-diffblue · web-flow · commit c12016b3e58d · 2020-06-30T15:20:20.000+01:00
Fix bug where reference to temporary string was returned
diff --git a/jbmc/unit/java-testing-utils/require_goto_statements.h b/jbmc/unit/java-testing-utils/require_goto_statements.h
@@ -34,19 +34,17 @@ class no_decl_found_exceptiont : public std::exception
 {
 public:
   explicit no_decl_found_exceptiont(const std::string &var_name)
-    : _varname(var_name)
+    : message{"Failed to find declaration for: " + var_name}
   {
   }
 
   virtual const char *what() const throw()
   {
-    std::ostringstream stringStream;
-    stringStream << "Failed to find declaration for: " << _varname;
-    return stringStream.str().c_str();
+    return message.c_str();
   }
 
 private:
-  std::string _varname;
+  std::string message;
 };
 
 pointer_assignment_locationt find_struct_component_assignments(

Original file line number	Diff line number	Diff line change
`@@ -34,19 +34,17 @@ class no_decl_found_exceptiont : public std::exception`
`34`	`34`	`{`
`35`	`35`	`public:`
`36`	`36`	`explicit no_decl_found_exceptiont(const std::string &var_name)`
`37`		`- : _varname(var_name)`
	`37`	`+ : message{"Failed to find declaration for: " + var_name}`
`38`	`38`	`{`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`virtual const char *what() const throw()`
`42`	`42`	`{`
`43`		`- std::ostringstream stringStream;`
`44`		`- stringStream << "Failed to find declaration for: " << _varname;`
`45`		`- return stringStream.str().c_str();`
	`43`	`+ return message.c_str();`
`46`	`44`	`}`
`47`	`45`
`48`	`46`	`private:`
`49`		`- std::string _varname;`
	`47`	`+ std::string message;`
`50`	`48`	`};`
`51`	`49`
`52`	`50`	`pointer_assignment_locationt find_struct_component_assignments(`